Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2927813004: PPC/s390: [debug] Untangle DebugInfo from break point support (Closed)

Created:
3 years, 6 months ago by JaideepBajwa
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [debug] Untangle DebugInfo from break point support Port d3371c23cb4b89da4f7b4ff09c11d594af213bc0 Original Commit Message: DebugInfo was very closely tied to break point support: * It contained only information relevant to break points. * It was created and freed by break point implementation. * Existence of a DebugInfo on the shared function info implied existence of break points. This CL is a step towards making DebugInfo usable by other debugging functionality such as block coverage by decoupling it from break point support, which is now only one kind of information stored on the DebugInfo object. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6000 LOG=N Review-Url: https://codereview.chromium.org/2927813004 Cr-Commit-Position: refs/heads/master@{#45796} Committed: https://chromium.googlesource.com/v8/v8/+/39e42b5ef08e8b6b28f060bb2f08b1149c458fbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +19 lines, -10 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 6 months ago (2017-06-08 20:46:31 UTC) #1
john.yan
lgtm
3 years, 6 months ago (2017-06-08 20:48:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927813004/1
3 years, 6 months ago (2017-06-08 20:48:41 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:09:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/39e42b5ef08e8b6b28f060bb2f08b1149c4...

Powered by Google App Engine
This is Rietveld 408576698