Add the new content widget including localised title.

Add the new content widget including localised title.

This is inspired by (aka basically copied from) the search widget. The
few bits of existing implementation are those that could be reused from
the search widget (the app opening code). In order to add unit tests I
had to move resources from being a dependency of the code to being a
dependency of the full appex (see build.gn files) as both widgets are
in the same unit test target and caused resource file name collisions.

BUG=622743
Review-Url: https://codereview.chromium.org/2927803002
Cr-Commit-Position: refs/heads/master@{#478577}
Committed: https://chromium.googlesource.com/chromium/src/+/45a4254da274bb79c1e0ad1a27c1644fc23156c3

[lody, 2017-06-07 16:05:54]

lod@chromium.org changed reviewers:
+ marq@chromium.org, scottmg@chromium.org

[lody, 2017-06-07 16:05:55]

scottmg: please review tools/gritsettings/*
marq: please review... the rest.

Thank you!

[scottmg, 2017-06-07 18:56:27]

tools lgtm

[marq (ping after 24h), 2017-06-08 08:49:57]

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
File ios/chrome/content_widget_extension/content_widget_view.mm (right):

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view.mm:14: @implementation
ContentWidgetView
Presumably something will be added here in future CLs?

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
File ios/chrome/content_widget_extension/content_widget_view_controller.mm
(right):

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:80: -
(BOOL)updateWidget {
This belongs in the 'internal' section, below.

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:81: return
NO;
Future CLs will actually perform an update?

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:135:
[sharedDefaults setObject:@{
Please extract the dictionary value out to a local variable to make this easier
to read.

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:153:
urlComponents.path = [NSString
Optional nit: to just concatenate two strings, use -stringByAppendingString:

[@"/" stringByAppendingString:base::SysUTF8....]

[lody, 2017-06-08 09:19:57]

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
File ios/chrome/content_widget_extension/content_widget_view.mm (right):

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view.mm:14: @implementation
ContentWidgetView
On 2017/06/08 08:49:56, marq (ping after 24h) wrote:
> Presumably something will be added here in future CLs?

haha, yes :D

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
File ios/chrome/content_widget_extension/content_widget_view_controller.mm
(right):

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:80: -
(BOOL)updateWidget {
On 2017/06/08 08:49:56, marq (ping after 24h) wrote:
> This belongs in the 'internal' section, below.

Done.

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:81: return
NO;
On 2017/06/08 08:49:57, marq (ping after 24h) wrote:
> Future CLs will actually perform an update?

Yes

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:135:
[sharedDefaults setObject:@{
On 2017/06/08 08:49:57, marq (ping after 24h) wrote:
> Please extract the dictionary value out to a local variable to make this
easier
> to read.

Done.

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:153:
urlComponents.path = [NSString
On 2017/06/08 08:49:56, marq (ping after 24h) wrote:
> Optional nit: to just concatenate two strings, use -stringByAppendingString:
> 
> [@"/" stringByAppendingString:base::SysUTF8....]

Done.

https://codereview.chromium.org/2927803002/diff/1/ios/chrome/content_widget_e...
ios/chrome/content_widget_extension/content_widget_view_controller.mm:153:
urlComponents.path = [NSString
On 2017/06/08 08:49:56, marq (ping after 24h) wrote:
> Optional nit: to just concatenate two strings, use -stringByAppendingString:
> 
> [@"/" stringByAppendingString:base::SysUTF8....]

Done.

[marq (ping after 24h), 2017-06-09 09:21:34]

lgtm

[lody, 2017-06-12 08:19:04]

The CQ bit was checked by lod@chromium.org

[lody, 2017-06-12 08:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2927803002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-06-12 08:19:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 10:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497255544855260,
"parent_rev": "a55a1b5dec7be5a660fd942f9f6946bf5ac425ff", "commit_rev":
"49dda7613ff1ccc6934ba81fb3dc928d1bcab79e"}

[commit-bot: I haz the power, 2017-06-12 10:15:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497255544855260,
"parent_rev": "1152a1ce4a45a9d2c97709f4cac931bb8028b33f", "commit_rev":
"45a4254da274bb79c1e0ad1a27c1644fc23156c3"}

[commit-bot: I haz the power, 2017-06-12 10:15:23]

Description was changed from

==========
Add the new content widget including localised title.

This is inspired by (aka basically copied from) the search widget. The
few bits of existing implementation are those that could be reused from
the search widget (the app opening code). In order to add unit tests I
had to move resources from being a dependency of the code to being a
dependency of the full appex (see build.gn files) as both widgets are
in the same unit test target and caused resource file name collisions.

BUG=622743
==========

to

==========
Add the new content widget including localised title.

This is inspired by (aka basically copied from) the search widget. The
few bits of existing implementation are those that could be reused from
the search widget (the app opening code). In order to add unit tests I
had to move resources from being a dependency of the code to being a
dependency of the full appex (see build.gn files) as both widgets are
in the same unit test target and caused resource file name collisions.

BUG=622743

Review-Url: https://codereview.chromium.org/2927803002
Cr-Commit-Position: refs/heads/master@{#478577}
Committed:
https://chromium.googlesource.com/chromium/src/+/45a4254da274bb79c1e0ad1a27c1...
==========

[commit-bot: I haz the power, 2017-06-12 10:15:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/45a4254da274bb79c1e0ad1a27c1...