Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 2927733002: Use destructive style for remove action (Closed)

Created:
3 years, 6 months ago by gambard
Modified:
3 years, 6 months ago
Reviewers:
lody
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use destructive style for remove action The remove actions of the context menus in ContentSuggestions should use the destructive style instead of the default style. BUG=724495 Review-Url: https://codereview.chromium.org/2927733002 Cr-Commit-Position: refs/heads/master@{#477583} Committed: https://chromium.googlesource.com/chromium/src/+/2467001e80f3a68ce060d2ec70633dc28145d952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 6 months ago (2017-06-07 07:34:14 UTC) #4
lody
lgtm
3 years, 6 months ago (2017-06-07 08:34:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927733002/1
3 years, 6 months ago (2017-06-07 08:35:08 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 08:38:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2467001e80f3a68ce060d2ec7063...

Powered by Google App Engine
This is Rietveld 408576698