Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2927703004:
Print Preview: Check capabilities before sending info ready (Closed)
DescriptionPrint Preview: Check capabilities before sending info ready
Check that capabilities is non-null before dispatching an INFO_READY
event that will trigger the print ticket store.
BUG=730874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2927703004
Cr-Commit-Position: refs/heads/master@{#478147}
Committed: https://chromium.googlesource.com/chromium/src/+/607f9a11ab0971f435775b2b2276e44a0a544d8d
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add notation #Messages
Total messages: 21 (16 generated)
Description was changed from ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 ========== to ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
rbpotter@chromium.org changed reviewers: + dpapad@chromium.org
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
LGTM with nit. https://codereview.chromium.org/2927703004/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2927703004/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/data/destination_store.js:700: * @private This function returns a boolean, but there is no @return. I am wondering how is this not causing a compiler error. Either way, can we add an @return (and explain what does the boolean actually mean)?
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
https://codereview.chromium.org/2927703004/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/2927703004/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/data/destination_store.js:700: * @private On 2017/06/08 01:22:14, dpapad wrote: > This function returns a boolean, but there is no @return. I am wondering how is > this not causing a compiler error. Either way, can we add an @return (and > explain what does the boolean actually mean)? Done. It indicates that fetch has been started. Looks like it will return true as long as the origin type is not PROFILE (or some non- valid value).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2927703004/#ps40001 (title: "Add notation")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496970291820830,
"parent_rev": "a01e1a70066880839f15b839a55157c003ade6ef", "commit_rev":
"607f9a11ab0971f435775b2b2276e44a0a544d8d"}
Message was sent while issue was closed.
Description was changed from ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Print Preview: Check capabilities before sending info ready Check that capabilities is non-null before dispatching an INFO_READY event that will trigger the print ticket store. BUG=730874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2927703004 Cr-Commit-Position: refs/heads/master@{#478147} Committed: https://chromium.googlesource.com/chromium/src/+/607f9a11ab0971f435775b2b2276... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/607f9a11ab0971f435775b2b2276... |
