Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2927703002:
chromium.fyi: Run Layout Tests on Swarming (on Linux bots). (Closed)
Descriptionchromium.fyi: Run Layout Tests on Swarming (on Linux bots).
Converts most of the Linux FYI bots to run layout tests on swarming.
Land https://crrev.com/c/532499 for the recipe side change after this CL lands.
BUG=703894, 524758
NOTRY=true
Review-Url: https://codereview.chromium.org/2927703002
Cr-Commit-Position: refs/heads/master@{#479964}
Committed: https://chromium.googlesource.com/chromium/src/+/2b36032776688471227ab1ebd9cb21faeb8e9bf4
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase onto master. #Patch Set 3 : Adding dummy builders #Patch Set 4 : Fixing dummy builder config? #Messages
Total messages: 34 (22 generated)
tansell@chromium.org changed reviewers: + dpranke@chromium.org, mcgreevy@chromium.org
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2927703002/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2927703002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10921: "os": "Ubuntu-14.04" Does this need an extra restriction for make it run on 32bit in some way?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The "Linux Trusty" and "Linux Trusty (32)" builders no longer exist, so you should just remove the entries for them in this file altogether. I think if you did want to target a 32-bit architecture, you'd say something like "arch": "x86-32", but we don't actually support 32-bit for the layout tests any more.
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. BUG=703894,524758 ========== to ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c532499 for the recipe side change after this CL lands. BUG=703894,524758 ==========
Description was changed from ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c532499 for the recipe side change after this CL lands. BUG=703894,524758 ========== to ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c/532499 for the recipe side change after this CL lands. BUG=703894,524758 ==========
tansell@chromium.org changed reviewers: + qyearsley@chromium.org
Hi! This is the src side of moving the Layout Tests from running locally on the BuildBot to running on swarming for the Linux bots. There are two bots which are two Linux bots added by Quinten which seem to be some type of "Dummy" builder? They don't seem to have relevant configs on the src side JSON file so I'm unsure if they should be converted. Adding CC to Alex Moshchuk as git blame claim they originally configured BlinkTest on the "Site Isolation" bot. Adding CC to Carlos Knippschild as git blame claims they original configured BlinkTest on the "Browser Side Navigation Linux" bot. Tim 'mithro' Ansell
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tansell@chromium.org
The CQ bit was unchecked by tansell@chromium.org
On 2017/06/13 08:52:21, mithro wrote: > Hi! > > This is the src side of moving the Layout Tests from running locally on the > BuildBot to running on swarming for the Linux bots. > > There are two bots which are two Linux bots added by Quinten which seem to be > some type of "Dummy" builder? They don't seem to have relevant configs on the > src side JSON file so I'm unsure if they should be converted. More about this: the two "Dummy" builders are there only to provide a config for two try bots with no corresponding actual continuous builders. This is done because in the chromium_tests recipe module, try bot configs are specified by specifying a corresponding continuous builder. Those two dummy configs are just special because they add extra args to run-webkit-tests by passing these args to steps.BlinkTest in the recipe-side config. What we want to do is have those try bots also use swarming, and add extra arguments to run-webkit-tests. I'm not sure, but maybe would be done by adding entries to these dummy builders in testing/buildbot/chromium.fyi.json, and then that config would be used for the corresponding try bots? (Is that right?) I notice that //testing/buildbot/tryserver.chromium.linux.json is empty; does the config for "Linux Tests" in //testing/buildbot/tryserver.chromium.linux.json apply to linux_chromium_rel_ng?
On 2017/06/13 16:11:22, qyearsley wrote: > On 2017/06/13 08:52:21, mithro wrote: > > Hi! > > > > This is the src side of moving the Layout Tests from running locally on the > > BuildBot to running on swarming for the Linux bots. > > > > There are two bots which are two Linux bots added by Quinten which seem to be > > some type of "Dummy" builder? They don't seem to have relevant configs on the > > src side JSON file so I'm unsure if they should be converted. > > More about this: the two "Dummy" builders are there only to provide a config for > two try bots with no corresponding actual continuous builders. This is done > because in the chromium_tests recipe module, try bot configs are specified by > specifying a corresponding continuous builder. > > Those two dummy configs are just special because they add extra args to > run-webkit-tests by passing these args to steps.BlinkTest in the recipe-side > config. > > What we want to do is have those try bots also use swarming, and add extra > arguments to run-webkit-tests. I'm not sure, but maybe would be done by adding > entries to these dummy builders in testing/buildbot/chromium.fyi.json, and then > that config would be used for the corresponding try bots? (Is that right?) > > I notice that //testing/buildbot/tryserver.chromium.linux.json is empty; does > the config for "Linux Tests" in //testing/buildbot/tryserver.chromium.linux.json > apply to linux_chromium_rel_ng? Yup, you've got this all correct. So, the "dummy" builders need to be switched as well.
I've added the dummy builders but I'm unsure that I have done so correctly. See https://codereview.chromium.org/2927703002/diff/60001/testing/buildbot/chromi... Can you confirm this is the right way so I can submit this change?
Yes, this looks correct. lgtm.
LGTM - I'm also not entirely sure, but the extra args listed in the config for these two dummy builders look correct!
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c/532499 for the recipe side change after this CL lands. BUG=703894,524758 ========== to ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c/532499 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ==========
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497593116225810,
"parent_rev": "3b25ca99578bd381854851fb98007fa56d380729", "commit_rev":
"2b36032776688471227ab1ebd9cb21faeb8e9bf4"}
Message was sent while issue was closed.
Description was changed from ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c/532499 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ========== to ========== chromium.fyi: Run Layout Tests on Swarming (on Linux bots). Converts most of the Linux FYI bots to run layout tests on swarming. Land https://crrev.com/c/532499 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2927703002 Cr-Commit-Position: refs/heads/master@{#479964} Committed: https://chromium.googlesource.com/chromium/src/+/2b36032776688471227ab1ebd9cb... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/2b36032776688471227ab1ebd9cb... |
