Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2927663003:
Fix Test.disableAnimationsAndTransitions to work with new /deep/ (Closed)
DescriptionFix Test.disableAnimationsAndTransitions to work with new /deep/
R=hcarmona@chromium.org
BUG=724597
Review-Url: https://codereview.chromium.org/2927663003
Cr-Commit-Position: refs/heads/master@{#477834}
Committed: https://chromium.googlesource.com/chromium/src/+/2deb8c3767fbb87c7fac334eda0624bc838903df
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== Fix Test.disabledAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=none ========== to ========== Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=none ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=none ========== to ========== Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=724597 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
LGTM, but will /deep/ be removed as a selector from querySelector eventually, or just from CSS rules?
On 2017/06/07 22:33:39, hcarmona wrote: > LGTM, but will /deep/ be removed as a selector from querySelector eventually, or > just from CSS rules? no, just css
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496875112740600, "parent_rev":
"19872caf752a64e53e0408d8d80f66729d3b703e", "commit_rev":
"2deb8c3767fbb87c7fac334eda0624bc838903df"}
Message was sent while issue was closed.
Description was changed from ========== Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=724597 ========== to ========== Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=724597 Review-Url: https://codereview.chromium.org/2927663003 Cr-Commit-Position: refs/heads/master@{#477834} Committed: https://chromium.googlesource.com/chromium/src/+/2deb8c3767fbb87c7fac334eda06... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2deb8c3767fbb87c7fac334eda06... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
