Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2927613002: Improve NSM handling. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org, regis
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -134 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 5 chunks +69 lines, -20 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 8 chunks +46 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 2 chunks +33 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 5 chunks +0 lines, -41 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 chunks +18 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_local_function_return_type.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/core_types.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/flutter.dart View 1 chunk +18 lines, -1 line 0 comments Download
M pkg/kernel/lib/target/targets.dart View 2 chunks +31 lines, -2 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 1 2 chunks +117 lines, -6 lines 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/lib/invocation_mirror_patch.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 4 chunks +0 lines, -20 lines 0 comments Download
M tests/language/language_kernel.status View 4 chunks +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 2926533004 Patch 20001

Messages

Total messages: 7 (2 generated)
ahe
3 years, 6 months ago (2017-06-06 18:14:14 UTC) #2
Paul Berry
lgtm assuming the comment below is addressed https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart File pkg/kernel/lib/core_types.dart (right): https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart#newcode210 pkg/kernel/lib/core_types.dart:210: Constructor get ...
3 years, 6 months ago (2017-06-06 18:26:07 UTC) #3
ahe
Thank you, Paul. https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart File pkg/kernel/lib/core_types.dart (right): https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart#newcode210 pkg/kernel/lib/core_types.dart:210: Constructor get noSuchMethodErrorDefaultConstructor { On 2017/06/06 ...
3 years, 6 months ago (2017-06-06 18:32:18 UTC) #4
ahe
https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart File pkg/kernel/lib/core_types.dart (right): https://codereview.chromium.org/2927613002/diff/1/pkg/kernel/lib/core_types.dart#newcode210 pkg/kernel/lib/core_types.dart:210: Constructor get noSuchMethodErrorDefaultConstructor { On 2017/06/06 18:32:17, ahe wrote: ...
3 years, 6 months ago (2017-06-07 07:02:33 UTC) #5
ahe
3 years, 6 months ago (2017-06-07 07:28:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d6a766bb146c65e4e4bf61a8d71d275d8d2d6e27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698