Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: pkg/kernel/lib/transformations/mixin_full_resolution.dart

Issue 2927613002: Improve NSM handling. (Closed)
Patch Set: Address review comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/target/vm.dart ('k') | runtime/lib/errors_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/transformations/mixin_full_resolution.dart
diff --git a/pkg/kernel/lib/transformations/mixin_full_resolution.dart b/pkg/kernel/lib/transformations/mixin_full_resolution.dart
index fcbc3092ada3dc3eee93b5a01fa32a481b1a2c36..42555e5f335d886c99c546db5aeaac5f2d4b34cb 100644
--- a/pkg/kernel/lib/transformations/mixin_full_resolution.dart
+++ b/pkg/kernel/lib/transformations/mixin_full_resolution.dart
@@ -200,7 +200,6 @@ class SuperCallResolutionTransformer extends Transformer {
final CoreTypes coreTypes;
final Class lookupClass;
final Target targetInfo;
- Constructor _invocationMirrorConstructor; // cached
SuperCallResolutionTransformer(
this.hierarchy, this.coreTypes, this.lookupClass, this.targetInfo);
@@ -296,13 +295,8 @@ class SuperCallResolutionTransformer extends Transformer {
/// Creates an "new _InvocationMirror(...)" invocation.
ConstructorInvocation _createInvocation(String methodName,
Arguments callArguments, bool isSuperInvocation, Expression receiver) {
- if (_invocationMirrorConstructor == null) {
- Class clazz = coreTypes.invocationMirrorClass;
- _invocationMirrorConstructor = clazz.constructors[0];
- }
-
- return targetInfo.instantiateInvocation(_invocationMirrorConstructor,
- receiver, methodName, callArguments, -1, isSuperInvocation);
+ return targetInfo.instantiateInvocation(
+ coreTypes, receiver, methodName, callArguments, -1, isSuperInvocation);
}
/// Check that a call to the targetFunction is legal given the arguments.
« no previous file with comments | « pkg/kernel/lib/target/vm.dart ('k') | runtime/lib/errors_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698