Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: tools/perf/page_sets/key_mobile_sites.py

Issue 2927583002: Revert of Explictly setting story names for rasterize_and_record_micro story sets (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/key_mobile_sites_pages.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 from page_sets import key_mobile_sites_pages 8 from page_sets import key_mobile_sites_pages
9 9
10 10
11 class KeyMobileSitesPage(page_module.Page): 11 class KeyMobileSitesPage(page_module.Page):
12 12
13 def __init__(self, url, page_set, name='', tags=None, 13 def __init__(self, url, page_set, name='', tags=None,
14 action_on_load_complete=False): 14 action_on_load_complete=False):
15 if name == '':
16 name = url
17 super(KeyMobileSitesPage, self).__init__( 15 super(KeyMobileSitesPage, self).__init__(
18 url=url, page_set=page_set, name=name, 16 url=url, page_set=page_set, name=name,
19 shared_page_state_class=shared_page_state.SharedMobilePageState, 17 shared_page_state_class=shared_page_state.SharedMobilePageState,
20 credentials_path='data/credentials.json', tags=tags) 18 credentials_path='data/credentials.json', tags=tags)
21 self.archive_data_file = 'data/key_mobile_sites.json' 19 self.archive_data_file = 'data/key_mobile_sites.json'
22 self.action_on_load_complete = action_on_load_complete 20 self.action_on_load_complete = action_on_load_complete
23 21
24 22
25 class KeyMobileSitesPageSet(story.StorySet): 23 class KeyMobileSitesPageSet(story.StorySet):
26 24
27 """ Key mobile sites with smooth interactions. """ 25 """ Key mobile sites with smooth interactions. """
28 26
29 def __init__(self): 27 def __init__(self):
30 super(KeyMobileSitesPageSet, self).__init__( 28 super(KeyMobileSitesPageSet, self).__init__(
31 archive_data_file='data/key_mobile_sites.json', 29 archive_data_file='data/key_mobile_sites.json',
32 cloud_storage_bucket=story.PARTNER_BUCKET, 30 cloud_storage_bucket=story.PARTNER_BUCKET)
33 verify_names=True)
34 31
35 32
36 # Add pages with predefined classes that contain custom navigation logic. 33 # Add pages with predefined classes that contain custom navigation logic.
37 predefined_page_classes = [ 34 predefined_page_classes = [
38 key_mobile_sites_pages.CapitolVolkswagenPage, 35 key_mobile_sites_pages.CapitolVolkswagenPage,
39 key_mobile_sites_pages.TheVergeArticlePage, 36 key_mobile_sites_pages.TheVergeArticlePage,
40 key_mobile_sites_pages.CnnArticlePage, 37 key_mobile_sites_pages.CnnArticlePage,
41 key_mobile_sites_pages.FacebookPage, 38 key_mobile_sites_pages.FacebookPage,
42 key_mobile_sites_pages.YoutubeMobilePage, 39 key_mobile_sites_pages.YoutubeMobilePage,
43 key_mobile_sites_pages.LinkedInPage, 40 key_mobile_sites_pages.LinkedInPage,
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 ('http://www.baidu.com/s?wd=barack+obama&rsv_bp=0&rsv_spt=3&rsv_sug3=9&' 167 ('http://www.baidu.com/s?wd=barack+obama&rsv_bp=0&rsv_spt=3&rsv_sug3=9&'
171 'rsv_sug=0&rsv_sug4=3824&rsv_sug1=3&inputT=4920'), 168 'rsv_sug=0&rsv_sug4=3824&rsv_sug1=3&inputT=4920'),
172 # Why: Top search engine 169 # Why: Top search engine
173 'http://www.bing.com/search?q=sloths', 170 'http://www.bing.com/search?q=sloths',
174 # Why: Good example of poor initial scrolling 171 # Why: Good example of poor initial scrolling
175 'http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans' 172 'http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans'
176 ] 173 ]
177 174
178 for url in urls_list: 175 for url in urls_list:
179 self.AddStory(KeyMobileSitesPage(url, self)) 176 self.AddStory(KeyMobileSitesPage(url, self))
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/key_mobile_sites_pages.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698