Upstream position: sticky parsing test to WPT

Upstream position: sticky parsing test to WPT

BUG=699244
Review-Url: https://codereview.chromium.org/2927453004
Cr-Commit-Position: refs/heads/master@{#477978}
Committed: https://chromium.googlesource.com/chromium/src/+/0f4041a691300b384f10f6b7749e06c6b5db9eb5

[smcgruer, 2017-06-06 14:51:54]

smcgruer@chromium.org changed reviewers:
+ flackr@chromium.org, yigu@chromium.org

[smcgruer, 2017-06-06 14:51:55]

PTAL. This may be overkill, lmk your thoughts.

One note in particular, Chrome will fail the test because of our lack of
table-row/etc support, but Firefox will fail the test because it resolves
'position: sticky' on table-column to 'sticky'. I'm not sure whether that
behavior (from Firefox) is correct per the spec.

[flackr, 2017-06-07 16:46:56]

https://codereview.chromium.org/2927453004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-parsing.html
(right):

https://codereview.chromium.org/2927453004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-parsing.html:52:
let style = `position: sticky; display: ${displayValue};`;
My only concern is whether any of these require a certain context for the
display to be applied. Do any of them that are supported by the browser not
match the display type? I think you can test for valid values which haven't been
applied in the context by comparing the inline style, e.g.
assert_equals(getComputedStyle(div).display, div.style.display);

[smcgruer, 2017-06-07 20:24:51]

So what do you think about the fact that both Chrome and Firefox will fail this
test? (For different reasons; Chrome fails from lack of table-row support,
Firefox because it returns 'sticky' for table-column).

https://codereview.chromium.org/2927453004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-parsing.html
(right):

https://codereview.chromium.org/2927453004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-parsing.html:52:
let style = `position: sticky; display: ${displayValue};`;
On 2017/06/07 16:46:56, flackr wrote:
> My only concern is whether any of these require a certain context for the
> display to be applied. Do any of them that are supported by the browser not
> match the display type? I think you can test for valid values which haven't
been
> applied in the context by comparing the inline style, e.g.
> assert_equals(getComputedStyle(div).display, div.style.display);

Tested, they're all good.

[flackr, 2017-06-07 20:39:32]

LGTM, I think it's fine if both browsers fail, they'll both have relevant error
messages to the issue.

[smcgruer, 2017-06-07 20:46:41]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 20:48:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 20:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 20:49:18]

Dry run: CQ cannot get SignCLA result. Please try later.

[smcgruer, 2017-06-08 13:03:46]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 13:03:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 13:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 13:05:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[smcgruer, 2017-06-08 13:57:31]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 13:57:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 15:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 15:20:01]

Dry run: This issue passed the CQ dry run.

[smcgruer, 2017-06-08 15:35:18]

The CQ bit was checked by smcgruer@chromium.org

[smcgruer, 2017-06-08 15:35:19]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org
Link to the patchset: https://codereview.chromium.org/2927453004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-08 15:35:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 15:40:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496936118932930,
"parent_rev": "ac69e2e7ab6df19a17f3f78126d3806706e93eff", "commit_rev":
"0f4041a691300b384f10f6b7749e06c6b5db9eb5"}

[commit-bot: I haz the power, 2017-06-08 15:40:44]

Description was changed from

==========
Upstream position: sticky parsing test to WPT

BUG=699244
==========

to

==========
Upstream position: sticky parsing test to WPT

BUG=699244

Review-Url: https://codereview.chromium.org/2927453004
Cr-Commit-Position: refs/heads/master@{#477978}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f4041a691300b384f10f6b7749e...
==========

[commit-bot: I haz the power, 2017-06-08 15:40:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0f4041a691300b384f10f6b7749e...