Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2927453003: md settings: Change color of error message from blue to red. (Closed)

Created:
3 years, 6 months ago by sammiequon
Modified:
3 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

md settings: Change color of error message from blue to red. Changed this in some other CL for local testing but got leaked through. BUG=729830 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2927453003 Cr-Commit-Position: refs/heads/master@{#477158} Committed: https://chromium.googlesource.com/chromium/src/+/e4c35e5205061e12103b3b02734b7fd76e045437

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 11 (6 generated)
sammiequon
stevenjb@ - Please take a look. Thanks! https://codereview.chromium.org/2927453003/diff/1/chrome/browser/resources/settings/people_page/setup_pin_dialog.html File chrome/browser/resources/settings/people_page/setup_pin_dialog.html (left): https://codereview.chromium.org/2927453003/diff/1/chrome/browser/resources/settings/people_page/setup_pin_dialog.html#oldcode17 chrome/browser/resources/settings/people_page/setup_pin_dialog.html:17: color: blue; ...
3 years, 6 months ago (2017-06-05 23:43:16 UTC) #4
stevenjb
lgtm
3 years, 6 months ago (2017-06-05 23:52:21 UTC) #5
sammiequon
On 2017/06/05 23:52:21, stevenjb wrote: > lgtm Thanks!
3 years, 6 months ago (2017-06-06 00:00:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927453003/1
3 years, 6 months ago (2017-06-06 00:01:10 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 02:30:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4c35e5205061e12103b3b02734b...

Powered by Google App Engine
This is Rietveld 408576698