Issue 292743020: [Telemetry] Reduce misleading spam in unittest output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292743020: [Telemetry] Reduce misleading spam in unittest output. (Closed)

Created:
6 years, 7 months ago by tonyg

Modified:
6 years, 7 months ago

Reviewers:
achuithb, dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Telemetry] Reduce misleading spam in unittest output. Sheriffs tend to get confused by stacks from intentional exceptions in gtest output. This should avoid us chasing red herrings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272302

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -14 lines)			Patch
M	tools/telemetry/telemetry/core/exceptions.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_unittest.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_unittest_base.py	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner.py	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/util/exception_formatter.py	View	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/292743020/1

6 years, 7 months ago (2014-05-22 18:32:41 UTC) #4

Message was sent while issue was closed.

Change committed as 272302

Expand Messages | Collapse Messages