tools/telemetry/telemetry/page/page_measurement_unittest.py - Issue 292743020: [Telemetry] Reduce misleading spam in unittest output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest.py

Issue 292743020: [Telemetry] Reduce misleading spam in unittest output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/exceptions.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest.py b/tools/telemetry/telemetry/page/page_measurement_unittest.py

index 63209e069c019a0340d7f7cedd8af0a9b7f5ca05..e81f2f49ad872472a204ef97be75984491dc1ba0 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest.py

@@ -6,6 +6,7 @@ import json

import os

from telemetry import test

+from telemetry.core import exceptions

from telemetry.core import wpr_modes

from telemetry.page import page as page_module

from telemetry.page import page_measurement

@@ -17,7 +18,7 @@ from telemetry.unittest import options_for_unittests

class MeasurementThatFails(page_measurement.PageMeasurement):

def MeasurePage(self, page, tab, results):

- raise page_measurement.MeasurementFailure('Intentional failure.')

+ raise exceptions.IntentionalException

class MeasurementThatHasDefaults(page_measurement.PageMeasurement):

def AddCommandLineArgs(self, parser):

« no previous file with comments | « tools/telemetry/telemetry/core/exceptions.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »