Issue 29273008: Revert r229533 "[GCM] Initial work to set up directory structure and introduce socket integration"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29273008: Revert r229533 "[GCM] Initial work to set up directory structure and introduce socket integration" (Closed)

Created:
7 years, 2 months ago by pfeldman

Modified:
7 years, 2 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert r229533 "[GCM] Initial work to set up directory structure and introduce socket integration" Breaks main waterfall. TBR=zea Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229543

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1053 lines)			Patch
M	build/all.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	google_apis/gcm/DEPS	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	google_apis/gcm/OWNERS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	google_apis/gcm/base/gcm_export.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	google_apis/gcm/base/socket_stream.h	View	1 chunk	+0 lines, -205 lines	0 comments	Download
D	google_apis/gcm/base/socket_stream.cc	View	1 chunk	+0 lines, -332 lines	0 comments	Download
D	google_apis/gcm/base/socket_stream_unittest.cc	View	1 chunk	+0 lines, -406 lines	0 comments	Download
D	google_apis/gcm/gcm.gyp	View	1 chunk	+0 lines, -56 lines	0 comments	Download
M	net/socket/socket_test_util.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/socket/socket_test_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

pfeldman

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28deps%29/builds/74754/steps/compile/logs/stdio

7 years, 2 months ago (2013-10-19 11:02:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r229543.