Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2927233003: Don't move raw pointers in HTMLCollection.h (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't move raw pointers in HTMLCollection.h Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=729393 Review-Url: https://codereview.chromium.org/2927233003 Cr-Commit-Position: refs/heads/master@{#478589} Committed: https://chromium.googlesource.com/chromium/src/+/48e5a7f1adf55ec695f3c24bdf648db251b933d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi Mike, Could you please review this? Thanks! Vaclav
3 years, 6 months ago (2017-06-09 13:17:19 UTC) #2
Mike West
lgtm
3 years, 6 months ago (2017-06-12 09:18:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927233003/1
3 years, 6 months ago (2017-06-12 09:18:12 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 11:03:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48e5a7f1adf55ec695f3c24bdf64...

Powered by Google App Engine
This is Rietveld 408576698