Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2444)

Unified Diff: chrome/test/data/webui/i18n_behavior_test.html

Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n() (Closed)
Patch Set: closure fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/i18n_behavior_test.html
diff --git a/chrome/test/data/webui/i18n_behavior_test.html b/chrome/test/data/webui/i18n_behavior_test.html
index 18eda268153068d874594bb3c351b7c40f441a8f..87e575fe44d73d4caddbadca2c312c14dc56c0d4 100644
--- a/chrome/test/data/webui/i18n_behavior_test.html
+++ b/chrome/test/data/webui/i18n_behavior_test.html
@@ -3,7 +3,8 @@
<body>
<script>
-/* Execute these tests with the browser_tests executable. */
+/* Execute these tests with the browser_tests executable with
+ * --gtest_filter='WebUIResourceBrowserTest.I18nBehaviorTest'. */
Dan Beam 2017/06/08 23:21:41 these instructions are not useful. i'd rather you
dschuyler 2017/06/09 00:13:39 Done.
var allowedByDefault = '<a href="https://google.com">Google!</a>';
var text = 'I\'m just text, nobody should have a problem with me!';
@@ -22,7 +23,6 @@ function setUpPage() {
}
function testI18n() {
- assertEquals(allowedByDefault, I18nBehavior.i18n('allowedByDefault'));
assertEquals(text, I18nBehavior.i18n('text'));
assertEquals(nonBreakingSpace, I18nBehavior.i18n('nonBreakingSpace'));
@@ -33,6 +33,9 @@ function testI18n() {
}
function testI18nAdvanced() {
+ assertEquals(
+ allowedByDefault,
+ I18nBehavior.i18nAdvanced('allowedByDefault'));
I18nBehavior.i18nAdvanced('customAttr', {
attrs: {
is: function(el, val) {

Powered by Google App Engine
This is Rietveld 408576698