Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2927193003: ClientCertStoreWin: do client cert and key lookup on SSLPlatformKeyTaskRunner. (Closed)

Created:
3 years, 6 months ago by mattm
Modified:
3 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ClientCertStoreWin: do client cert and key lookup on SSLPlatformKeyTaskRunner. When USE_BYTE_CERTS=true and X509Certificate is no longer holding PCCERT_CONTEXT handles, it is safe to move these off the IO thread. BUG=394131 Review-Url: https://codereview.chromium.org/2927193003 Cr-Commit-Position: refs/heads/master@{#481309} Committed: https://chromium.googlesource.com/chromium/src/+/0f29527597298df4a879ee6e8bd082993248c740

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M net/ssl/client_cert_store_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/ssl/client_cert_store_win.cc View 1 7 chunks +36 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (15 generated)
mattm
followup to https://codereview.chromium.org/2913253003/
3 years, 6 months ago (2017-06-16 22:48:16 UTC) #10
davidben
lgtm!
3 years, 6 months ago (2017-06-16 23:08:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927193003/20001
3 years, 6 months ago (2017-06-21 19:29:14 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 21:31:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f29527597298df4a879ee6e8bd0...

Powered by Google App Engine
This is Rietveld 408576698