Omnibox UI: Create right-margin on Cocoa dropdown

Omnibox UI: Create right-margin on Cocoa dropdown

BUG=729197
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2927193002
Cr-Commit-Position: refs/heads/master@{#478801}
Committed: https://chromium.googlesource.com/chromium/src/+/7b56a5733a6ded284c245018071328dbb99aadb5

[tommycli, 2017-06-08 21:37:44]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 21:38:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-06-08 21:42:35]

tommycli@chromium.org changed reviewers:
+ shrike@chromium.org

[tommycli, 2017-06-08 21:42:36]

shrike: PTAL, screenshot in bug.

Thanks. Tommy

[commit-bot: I haz the power, 2017-06-08 22:00:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 22:00:10]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-06-09 00:07:58]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org

[tommycli, 2017-06-09 00:07:59]

groby: PTAL, adding you for OWNER, thanks

[tommycli, 2017-06-09 21:32:45]

shrike: ping, thanks!

[groby-ooo-7-16, 2017-06-09 21:40:43]

On 2017/06/09 21:32:45, tommycli wrote:
> shrike: ping, thanks!

Do you need both of us to review?

[tommycli, 2017-06-09 21:56:11]

On 2017/06/09 21:40:43, groby wrote:
> On 2017/06/09 21:32:45, tommycli wrote:
> > shrike: ping, thanks!
> 
> Do you need both of us to review?

groby: I only added you because you're the technical OWNER. I think shrike@ is
probably the more suitable reviewer, but he's not OWNER on these files.

[tommycli, 2017-06-09 21:56:47]

On 2017/06/09 21:56:11, tommycli wrote:
> On 2017/06/09 21:40:43, groby wrote:
> > On 2017/06/09 21:32:45, tommycli wrote:
> > > shrike: ping, thanks!
> > 
> > Do you need both of us to review?
> 
> groby: I only added you because you're the technical OWNER. I think shrike@ is
> probably the more suitable reviewer, but he's not OWNER on these files.

Though it seems like he really should be.

[tommycli, 2017-06-12 14:49:56]

On 2017/06/09 21:56:47, tommycli wrote:
> On 2017/06/09 21:56:11, tommycli wrote:
> > On 2017/06/09 21:40:43, groby wrote:
> > > On 2017/06/09 21:32:45, tommycli wrote:
> > > > shrike: ping, thanks!
> > > 
> > > Do you need both of us to review?
> > 
> > groby: I only added you because you're the technical OWNER. I think shrike@
is
> > probably the more suitable reviewer, but he's not OWNER on these files.
> 
> Though it seems like he really should be.

shrike: PTAL, thanks!

[shrike, 2017-06-12 15:42:54]

On 2017/06/12 14:49:56, tommycli wrote:
> shrike: PTAL, thanks!

Sorry - traveling last Friday and today is chopped up for me (and I need to
update the repo on my laptop to patch this in). Hopefully will be able to review
this morning before I have to head out.

[tommycli, 2017-06-12 15:47:29]

On 2017/06/12 15:42:54, shrike wrote:
> On 2017/06/12 14:49:56, tommycli wrote:
> > shrike: PTAL, thanks!
> 
> Sorry - traveling last Friday and today is chopped up for me (and I need to
> update the repo on my laptop to patch this in). Hopefully will be able to
review
> this morning before I have to head out.

Hey Jayson, no worries and no rush. You can also view on my machine if you need.

I only pinged to make sure my prev. message didn't get lost in email.

[shrike, 2017-06-12 20:43:55]

lgtm

[tommycli, 2017-06-12 22:15:12]

Description was changed from

==========
Omnibox UI: Create right-margin on Cocoa dropdown

BUG=729197
==========

to

==========
Omnibox UI: Create right-margin on Cocoa dropdown

BUG=729197
TBR=groby@chromium.org
==========

[tommycli, 2017-06-12 22:15:20]

On 2017/06/12 20:43:55, shrike wrote:
> lgtm

thanks! submitting!

[tommycli, 2017-06-12 22:15:26]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:15:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:19:22]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2017-06-12 22:27:14]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-06-12 22:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2927193002/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2017-06-12 22:27:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:53:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497306434926340,
"parent_rev": "6cdbe5061c8a26d0b9647d13c1d89e9d152491db", "commit_rev":
"7b56a5733a6ded284c245018071328dbb99aadb5"}

[commit-bot: I haz the power, 2017-06-12 22:53:56]

Description was changed from

==========
Omnibox UI: Create right-margin on Cocoa dropdown

BUG=729197
TBR=groby@chromium.org
==========

to

==========
Omnibox UI: Create right-margin on Cocoa dropdown

BUG=729197
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2927193002
Cr-Commit-Position: refs/heads/master@{#478801}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b56a5733a6ded284c2450180713...
==========

[commit-bot: I haz the power, 2017-06-12 22:53:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b56a5733a6ded284c2450180713...