Prevent CompositingHelper from prematurely Satisfying Surface reference

Prevent CompositingHelper from prematurely Satisfying Surface reference

When ChildFrameCompositingHelper::OnSetSurface receives a reference to
a new Surface, it creates a SurfaceLayer and then sends a
FrameHostMsg_SatisfySequence message to the browser to release a
temporary reference that was keeping the Surface alive in the meantime.

The SurfaceLayer creates a new reference to the Surface by sending a
FrameHostMsg_RequireSurface message, but this doesn't happen until
the SurfaceLayer is attached to the layer tree, which is not until the
next BeginMainFrame. Therefore the SurfaceManager was seeing the only
reference to the Surface satisfied before receiving another Require on
it, and this was causing OOPIF flickering during scrolling.

This CL delays when ChildFrameCompositorFrame sends the Satisfy
message, caching the SurfaceSequence until after the SurfaceLayer is
attached to the layer tree.

BUG=701175
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927173002
Cr-Commit-Position: refs/heads/master@{#478434}
Committed: https://chromium.googlesource.com/chromium/src/+/6ef29daef4aa32b5c744c645891ac4595bc4d073

[kenrb, 2017-06-08 20:08:11]

Description was changed from

==========
Prevent CompositingHelper from prematurely Satisfying Surface reference

When ChildFrameCompositingHelper::OnSetSurface receives a reference to
a new Surface, it creates a SurfaceLayer and then sends a
FrameHostMsg_SatisfySequence message to the browser to release a
temporary reference that was keeping the Surface alive in the meantime.

The SurfaceLayer creates a new reference to the Surface by sending a
FrameHostMsg_RequireSurface message, but this doesn't happen until
the SurfaceLayer is attached to the layer tree, which is not until the
next BeginMainFrame. Therefore the SurfaceManager was seeing the only
reference to the Surface satisfied before receiving another Require on
it, and this was causing OOPIF flickering during scrolling.

This CL delays when ChildFrameCompositorFrame sends the Satisfy
message, caching the SurfaceSequence until after the SurfaceLayer is
attached to the layer tree.

BUG=701175
==========

to

==========
Prevent CompositingHelper from prematurely Satisfying Surface reference

When ChildFrameCompositingHelper::OnSetSurface receives a reference to
a new Surface, it creates a SurfaceLayer and then sends a
FrameHostMsg_SatisfySequence message to the browser to release a
temporary reference that was keeping the Surface alive in the meantime.

The SurfaceLayer creates a new reference to the Surface by sending a
FrameHostMsg_RequireSurface message, but this doesn't happen until
the SurfaceLayer is attached to the layer tree, which is not until the
next BeginMainFrame. Therefore the SurfaceManager was seeing the only
reference to the Surface satisfied before receiving another Require on
it, and this was causing OOPIF flickering during scrolling.

This CL delays when ChildFrameCompositorFrame sends the Satisfy
message, caching the SurfaceSequence until after the SurfaceLayer is
attached to the layer tree.

BUG=701175
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[kenrb, 2017-06-08 20:10:10]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:10:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-06-08 20:24:50]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:25:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-06-08 20:56:33]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:56:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-06-08 20:58:47]

kenrb@chromium.org changed reviewers:
+ piman@chromium.org

[kenrb, 2017-06-08 20:58:48]

piman: PTAL?

[commit-bot: I haz the power, 2017-06-08 21:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 21:59:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[piman, 2017-06-09 20:35:00]

LGTM. I would have a few suggestions to make it a bit more robust/rational, but
since surface sequence are going to be replaced by surface references, a lot of
this will go away for the better, so probably not worth refactoring.

[kenrb, 2017-06-09 20:38:41]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2017-06-09 20:39:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 22:16:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497040721276130,
"parent_rev": "9208d8ba4573a393b9b034555757cb8252a89c0b", "commit_rev":
"6ef29daef4aa32b5c744c645891ac4595bc4d073"}

[commit-bot: I haz the power, 2017-06-09 22:16:34]

Description was changed from

==========
Prevent CompositingHelper from prematurely Satisfying Surface reference

When ChildFrameCompositingHelper::OnSetSurface receives a reference to
a new Surface, it creates a SurfaceLayer and then sends a
FrameHostMsg_SatisfySequence message to the browser to release a
temporary reference that was keeping the Surface alive in the meantime.

The SurfaceLayer creates a new reference to the Surface by sending a
FrameHostMsg_RequireSurface message, but this doesn't happen until
the SurfaceLayer is attached to the layer tree, which is not until the
next BeginMainFrame. Therefore the SurfaceManager was seeing the only
reference to the Surface satisfied before receiving another Require on
it, and this was causing OOPIF flickering during scrolling.

This CL delays when ChildFrameCompositorFrame sends the Satisfy
message, caching the SurfaceSequence until after the SurfaceLayer is
attached to the layer tree.

BUG=701175
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prevent CompositingHelper from prematurely Satisfying Surface reference

When ChildFrameCompositingHelper::OnSetSurface receives a reference to
a new Surface, it creates a SurfaceLayer and then sends a
FrameHostMsg_SatisfySequence message to the browser to release a
temporary reference that was keeping the Surface alive in the meantime.

The SurfaceLayer creates a new reference to the Surface by sending a
FrameHostMsg_RequireSurface message, but this doesn't happen until
the SurfaceLayer is attached to the layer tree, which is not until the
next BeginMainFrame. Therefore the SurfaceManager was seeing the only
reference to the Surface satisfied before receiving another Require on
it, and this was causing OOPIF flickering during scrolling.

This CL delays when ChildFrameCompositorFrame sends the Satisfy
message, caching the SurfaceSequence until after the SurfaceLayer is
attached to the layer tree.

BUG=701175
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927173002
Cr-Commit-Position: refs/heads/master@{#478434}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ef29daef4aa32b5c744c645891a...
==========

[commit-bot: I haz the power, 2017-06-09 22:16:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6ef29daef4aa32b5c744c645891a...