wm: Do not resize when switching users if window is already maximized.

wm: Do not resize when switching users if window is already maximized.

Extends crbug.com/385992 to work when more than one displays are attached. More details in bug and crbug.com/385992.

TEST=unit_tests --gtest_filter="MultiUserWindowManagerChromeOSTest.TestBlackBarCover"
BUG=609501
Review-Url: https://codereview.chromium.org/2927163002
Cr-Commit-Position: refs/heads/master@{#480081}
Committed: https://chromium.googlesource.com/chromium/src/+/1e73e98a5aa5a31e4e4bdc17c1a945a631cedb76

[sammiequon, 2017-06-08 18:05:38]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 18:05:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 18:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 18:40:06]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-06-08 18:47:05]

Description was changed from

==========
wm: Do not resize when switching users if window is already maximized.

Extends crbug.com/385992 to work when more than one displays are attached. More
details in bug and crbug.com/385992.

TEST=unit_tests
--gtest_filter="MultiUserWindowManagerChromeOSTest.TestBlackBarCover"
BUG=609501
==========

to

==========
wm: Do not resize when switching users if window is already maximized.

Extends crbug.com/385992 to work when more than one displays are attached. More
details in bug and crbug.com/385992.

TEST=unit_tests
--gtest_filter="MultiUserWindowManagerChromeOSTest.TestBlackBarCover"
BUG=609501
==========

[sammiequon, 2017-06-08 18:47:05]

sammiequon@chromium.org changed reviewers:
+ skuhne@chromium.org

[sammiequon, 2017-06-08 18:47:46]

skuhne@ - Please take a look. Thanks!

[sammiequon, 2017-06-09 18:46:20]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 18:46:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 19:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 19:26:34]

Dry run: This issue passed the CQ dry run.

[Mr4D (OOO till 08-26), 2017-06-09 23:50:26]

https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
File chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc (right):

https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc:151: return
work_area.size() == bounds.size();
If you have a window which has the same size as maximized - but it is not, the
user can move it off the origin of the screen (which might not even be (0,0) but
(shelfwidth, 0) ) and then this would be reported as covers screen - which it is
not.

[sammiequon, 2017-06-10 00:04:50]

https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
File chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc (right):

https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc:151: return
work_area.size() == bounds.size();
On 2017/06/09 23:50:25, Mr4D wrote:
> If you have a window which has the same size as maximized - but it is not, the
> user can move it off the origin of the screen (which might not even be (0,0)
but
> (shelfwidth, 0) ) and then this would be reported as covers screen - which it
is
> not.

I see, I *think* GetBoundsInScreen() would do.

[sammiequon, 2017-06-15 19:34:13]

On 2017/06/10 00:04:50, sammiequon wrote:
>
https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
> File chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
(right):
> 
>
https://codereview.chromium.org/2927163002/diff/20001/chrome/browser/ui/ash/m...
> chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc:151: return
> work_area.size() == bounds.size();
> On 2017/06/09 23:50:25, Mr4D wrote:
> > If you have a window which has the same size as maximized - but it is not,
the
> > user can move it off the origin of the screen (which might not even be (0,0)
> but
> > (shelfwidth, 0) ) and then this would be reported as covers screen - which
it
> is
> > not.
> 
> I see, I *think* GetBoundsInScreen() would do.

skuhne@ - Ping! Please take a look.

[Mr4D (OOO till 08-26), 2017-06-15 20:56:26]

lgtm

[sammiequon, 2017-06-15 21:24:44]

On 2017/06/15 20:56:26, Mr4D wrote:
> lgtm

Thanks!

[sammiequon, 2017-06-16 16:30:43]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-06-16 16:31:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 17:04:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497630643653420,
"parent_rev": "7edb4dccf29277365a5b447887ad9c1e56ac6be8", "commit_rev":
"1e73e98a5aa5a31e4e4bdc17c1a945a631cedb76"}

[commit-bot: I haz the power, 2017-06-16 17:04:50]

Description was changed from

==========
wm: Do not resize when switching users if window is already maximized.

Extends crbug.com/385992 to work when more than one displays are attached. More
details in bug and crbug.com/385992.

TEST=unit_tests
--gtest_filter="MultiUserWindowManagerChromeOSTest.TestBlackBarCover"
BUG=609501
==========

to

==========
wm: Do not resize when switching users if window is already maximized.

Extends crbug.com/385992 to work when more than one displays are attached. More
details in bug and crbug.com/385992.

TEST=unit_tests
--gtest_filter="MultiUserWindowManagerChromeOSTest.TestBlackBarCover"
BUG=609501

Review-Url: https://codereview.chromium.org/2927163002
Cr-Commit-Position: refs/heads/master@{#480081}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e73e98a5aa5a31e4e4bdc17c1a9...
==========

[commit-bot: I haz the power, 2017-06-16 17:04:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1e73e98a5aa5a31e4e4bdc17c1a9...