Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2927123005: Deprecate step timing with position 'middle' (Closed)

Created:
3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 6 months ago
Reviewers:
dcheng, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, lunalu1, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate step timing with position 'middle' This patch adds a deprecation warning and UseCounter for instances of the step animation timing function with step position 'middle' and the keyword 'step-middle'. This patch also adds a dummy document to TimingInputTest in order to maintain the invariant that if step-middle is allowed then a non-null Document* is provided for the UseCounter. BUG=646265 Review-Url: https://codereview.chromium.org/2927123005 Cr-Commit-Position: refs/heads/master@{#478914} Committed: https://chromium.googlesource.com/chromium/src/+/4cd8966bc2b20f69b9b23d2538eb25452775134e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -33 lines) Patch
A third_party/WebKit/LayoutTests/animations/step-middle-keyword-timing-function-deprecated.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/step-middle-keyword-timing-function-deprecated-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/step-middle-timing-function-deprecated.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/step-middle-timing-function-deprecated-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/timing-functions.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/TimingInputTest.cpp View 15 chunks +49 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp View 4 chunks +20 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebFeature.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
suzyh_UTC10 (ex-contributor)
3 years, 6 months ago (2017-06-09 05:27:22 UTC) #2
Eric Willigers
lgtm
3 years, 6 months ago (2017-06-09 06:10:21 UTC) #4
suzyh_UTC10 (ex-contributor)
+dcheng for core/frame and public/platform OWNERS I made a mistake during rebase, but I think ...
3 years, 6 months ago (2017-06-13 00:38:00 UTC) #9
Eric Willigers
> Would you mind doing a quick sanity-check that it all still looks good? done, ...
3 years, 6 months ago (2017-06-13 00:44:10 UTC) #10
dcheng
lgtm
3 years, 6 months ago (2017-06-13 04:59:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927123005/20001
3 years, 6 months ago (2017-06-13 05:00:21 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 06:37:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cd8966bc2b20f69b9b23d2538eb...

Powered by Google App Engine
This is Rietveld 408576698