Deprecate step timing with position 'middle'
This patch adds a deprecation warning and UseCounter for instances of
the step animation timing function with step position 'middle' and the
keyword 'step-middle'.
This patch also adds a dummy document to TimingInputTest in order to
maintain the invariant that if step-middle is allowed then a non-null
Document* is provided for the UseCounter.
BUG=646265
Review-Url: https://codereview.chromium.org/2927123005
Cr-Commit-Position: refs/heads/master@{#478914}
Committed: https://chromium.googlesource.com/chromium/src/+/4cd8966bc2b20f69b9b23d2538eb25452775134e
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/475255)
3 years, 6 months ago
(2017-06-09 08:30:18 UTC)
#7
+dcheng for core/frame and public/platform OWNERS I made a mistake during rebase, but I think ...
3 years, 6 months ago
(2017-06-13 00:38:00 UTC)
#9
+dcheng for core/frame and public/platform OWNERS
I made a mistake during rebase, but I think I've fixed it up. Main difference to
patch 1 should be adding the counter to WebFeature.h instead of
UseCounterFeature.def. ericwilligers: Would you mind doing a quick sanity-check
that it all still looks good?
Eric Willigers
> Would you mind doing a quick sanity-check that it all still looks good? done, ...
3 years, 6 months ago
(2017-06-13 00:44:10 UTC)
#10
> Would you mind doing a quick sanity-check
that it all still looks good?
done, still lgtm
dcheng
lgtm
3 years, 6 months ago
(2017-06-13 04:59:24 UTC)
#11
lgtm
suzyh_UTC10 (ex-contributor)
The CQ bit was checked by suzyh@chromium.org
3 years, 6 months ago
(2017-06-13 04:59:59 UTC)
#12
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497329999807790, "parent_rev": "a01ec54e907dcda55f339330da7c05149295131b", "commit_rev": "4cd8966bc2b20f69b9b23d2538eb25452775134e"}
3 years, 6 months ago
(2017-06-13 06:37:25 UTC)
#14
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497329999807790,
"parent_rev": "a01ec54e907dcda55f339330da7c05149295131b", "commit_rev":
"4cd8966bc2b20f69b9b23d2538eb25452775134e"}
commit-bot: I haz the power
Description was changed from ========== Deprecate step timing with position 'middle' This patch adds a ...
3 years, 6 months ago
(2017-06-13 06:37:35 UTC)
#15
Message was sent while issue was closed.
Description was changed from
==========
Deprecate step timing with position 'middle'
This patch adds a deprecation warning and UseCounter for instances of
the step animation timing function with step position 'middle' and the
keyword 'step-middle'.
This patch also adds a dummy document to TimingInputTest in order to
maintain the invariant that if step-middle is allowed then a non-null
Document* is provided for the UseCounter.
BUG=646265
==========
to
==========
Deprecate step timing with position 'middle'
This patch adds a deprecation warning and UseCounter for instances of
the step animation timing function with step position 'middle' and the
keyword 'step-middle'.
This patch also adds a dummy document to TimingInputTest in order to
maintain the invariant that if step-middle is allowed then a non-null
Document* is provided for the UseCounter.
BUG=646265
Review-Url: https://codereview.chromium.org/2927123005
Cr-Commit-Position: refs/heads/master@{#478914}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cd8966bc2b20f69b9b23d2538eb...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4cd8966bc2b20f69b9b23d2538eb25452775134e
3 years, 6 months ago
(2017-06-13 06:37:37 UTC)
#16
Issue 2927123005: Deprecate step timing with position 'middle'
(Closed)
Created 3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified 3 years, 6 months ago
Reviewers: dcheng, Eric Willigers
Base URL:
Comments: 0