Chromium Code Reviews| Index: content/browser/frame_host/navigation_request.cc |
| diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc |
| index dee3a58b6062ec0d4149f9987fbe643216bec222..f081068e17aa8e19db44e51e6b9a0f7ddba8c559 100644 |
| --- a/content/browser/frame_host/navigation_request.cc |
| +++ b/content/browser/frame_host/navigation_request.cc |
| @@ -277,7 +277,6 @@ std::unique_ptr<NavigationRequest> NavigationRequest::CreateRendererInitiated( |
| // navigation may start in a renderer and commit in another one. |
| // TODO(clamy): See if the navigation start time should be measured in the |
| // renderer and sent to the browser instead of being measured here. |
| - // TODO(clamy): The pending history list offset should be properly set. |
| RequestNavigationParams request_params( |
| false, // is_overriding_user_agent |
| std::vector<GURL>(), // redirects |
| @@ -289,7 +288,8 @@ std::unique_ptr<NavigationRequest> NavigationRequest::CreateRendererInitiated( |
| std::map<std::string, bool>(), // subframe_unique_names |
| frame_tree_node->has_committed_real_load(), |
| false, // intended_as_new_entry |
| - -1, // pending_history_list_offset |
| + -1, // |pending_history_list_offset| is set to -1 because |
| + // history-navigations doesn't use this path. See comments above. |
|
nasko
2017/06/09 22:29:24
nit: s/doesn't/do not/ or if you prefer "don't".
|
| current_history_list_offset, current_history_list_length, |
| false, // is_view_source |
| false, // should_clear_history_list |