Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2927023003: Added CSSPropertyBorderImageUtils which holds shared parsing logic. (Closed)

Created:
3 years, 6 months ago by Bugs Nash
Modified:
3 years, 6 months ago
Reviewers:
nainar, Jia
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added CSSPropertyBorderImageUtils which holds shared parsing logic. Added CSSPropertyBorderImageUtils which holds shared border image parsing logic. This patch - Added CSSPropertyBorderImageUtils.h and CSSPropertyBorderImageUtils.cpp - Moved the following methods from CSSPropertyParser.cpp to CSSPropertyBorderImageUtils as public utils - ConsumeWebkitBorderImage - ConsumeBorderImageComponents - ConsumeBorderImageRepeat - ConsumeBorderImageSlice - ConsumeBorderImageWidth - ConsumeBorderImageOutset - Moved ConsumeBorderImageRepeatKeyword from CSSPropertyParser.cpp to CSSPropertyBorderImageUtils.cpp as a private method in an unnamed namespace This is prework to move ParseSingleValue logic from CSSPropertyParser to the property API for CSSPropertyWebkitBorderImage BUG=668012 Review-Url: https://codereview.chromium.org/2927023003 Cr-Commit-Position: refs/heads/master@{#478867} Committed: https://chromium.googlesource.com/chromium/src/+/a04bddb2a71bfac55dff9b3e2d74e31a05e81ce0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -155 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 7 chunks +13 lines, -155 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyBorderImageUtils.cpp View 1 chunk +182 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Bugs Nash
3 years, 6 months ago (2017-06-09 04:44:55 UTC) #4
nainar
lgtm
3 years, 6 months ago (2017-06-09 07:47:51 UTC) #7
Bugs Nash
+jiameng for Ribbon review
3 years, 6 months ago (2017-06-12 23:55:42 UTC) #9
Jia
lgtm
3 years, 6 months ago (2017-06-13 00:13:24 UTC) #10
Jia
lgtm
3 years, 6 months ago (2017-06-13 00:13:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927023003/1
3 years, 6 months ago (2017-06-13 00:15:28 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 02:18:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a04bddb2a71bfac55dff9b3e2d74...

Powered by Google App Engine
This is Rietveld 408576698