Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2927013002: Move "sentence" granularity related functions to VisibleUnitSentence.cpp (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move "sentence" granularity related functions to VisibleUnitSentence.cpp This patch moves "sentence" granularity related functions to "VisibleUnitSentence.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2927013002 Cr-Commit-Position: refs/heads/master@{#478149} Committed: https://chromium.googlesource.com/chromium/src/+/69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492

Patch Set 1 : 2017-06-08T17:39:57 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -126 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +0 lines, -126 lines 0 comments Download
A third_party/WebKit/Source/core/editing/VisibleUnitsSentence.cpp View 1 chunk +163 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-08 08:57:30 UTC) #5
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-08 20:31:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927013002/1
3 years, 6 months ago (2017-06-09 01:06:20 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 01:10:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69ea6604a7a96b6cdca71aa43a0e...

Powered by Google App Engine
This is Rietveld 408576698