Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2926903003: Revert "Remove unit tests from ios-simulator that are timing out." (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
Reviewers:
liaoyuke, Dirk Pranke
CC:
chromium-reviews, ios-reviews_chromium.org, rohitrao (ping after 24h)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove unit tests from ios-simulator that are timing out." This reverts commit a27564e55ec5fd0ff168c23d927c68dec145871c. Individual tests have been disabled, and the rest of the suite has run successfully on FYI. BUG= Review-Url: https://codereview.chromium.org/2926903003 Cr-Commit-Position: refs/heads/master@{#477844} Committed: https://chromium.googlesource.com/chromium/src/+/37e21d50eb77c515341932f63109afdd9a27e1ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/build/bots/tests/common_tests.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
baxley
Individual tests were disabled, and ios_chrome_unittests or net_unittests haven't failed in at least 5 runs ...
3 years, 6 months ago (2017-06-07 18:38:03 UTC) #2
liaoyuke
lgtm
3 years, 6 months ago (2017-06-07 18:47:32 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-07 19:14:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926903003/1
3 years, 6 months ago (2017-06-07 19:19:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/463169)
3 years, 6 months ago (2017-06-07 19:29:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926903003/1
3 years, 6 months ago (2017-06-07 19:38:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/232806)
3 years, 6 months ago (2017-06-07 21:44:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926903003/1
3 years, 6 months ago (2017-06-07 22:27:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/233011)
3 years, 6 months ago (2017-06-07 23:48:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926903003/1
3 years, 6 months ago (2017-06-08 00:30:41 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 01:03:41 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37e21d50eb77c515341932f63109...

Powered by Google App Engine
This is Rietveld 408576698