Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2926873002: Convert css3/blending/svg-blend-multiply-alpha to a pixel test (Closed)

Created:
3 years, 6 months ago by f(malita)
Modified:
3 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert css3/blending/svg-blend-multiply-alpha to a pixel test 1) we're now rendering differently on Mac 2) the ref has hard-coded colors, so there's little/no value over a pixel test BUG=730071 TBR=mtklein@chromium.org,dpranke@chromium.org Review-Url: https://codereview.chromium.org/2926873002 Cr-Commit-Position: refs/heads/master@{#477712} Committed: https://chromium.googlesource.com/chromium/src/+/615a5e37d56eec7fc90a93f7ce650c5c345ab167

Patch Set 1 #

Patch Set 2 : rebaseline all platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/blending/svg-blend-multiply-alpha-expected.html View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
f(malita)
3 years, 6 months ago (2017-06-07 14:29:34 UTC) #5
mtklein_C
Oh how elegant. lgtm
3 years, 6 months ago (2017-06-07 14:32:15 UTC) #6
reed1
lgtm
3 years, 6 months ago (2017-06-07 14:33:22 UTC) #7
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-07 15:14:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926873002/20001
3 years, 6 months ago (2017-06-07 17:13:19 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 18:46:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/615a5e37d56eec7fc90a93f7ce65...

Powered by Google App Engine
This is Rietveld 408576698