Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2926793002:
Use ContainsValue() instead of std::find() in ui/wm and ui/message_center (Closed)
DescriptionUse ContainsValue() instead of std::find() in ui/wm and ui/message_center
BUG=561800
Review-Url: https://codereview.chromium.org/2926793002
Cr-Commit-Position: refs/heads/master@{#478550}
Committed: https://chromium.googlesource.com/chromium/src/+/602d0022f1db92aa45aeed42a712f9eccc29ac8d
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added a blank line. #
Total comments: 2
Patch Set 3 : Changed EXPECT_TRUE to EXPECT_FALSE #
Messages
Total messages: 33 (18 generated)
Description was changed from ========== Use ContainsValue() instead of std::find() in ui/wm and ui/message_center BUG=561800 ========== to ========== Use ContainsValue() instead of std::find() in ui/wm and ui/message_center BUG=561800 ==========
tripta.g@samsung.com changed reviewers: + a.suchit@samsung.com
Please review the code changes
a.suchit@chromium.org changed reviewers: + a.suchit@chromium.org
https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/mes... File ui/message_center/views/message_list_view.cc (right): https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/mes... ui/message_center/views/message_list_view.cc:5: #include "ui/message_center/views/message_list_view.h" one empty line required after line 5.
Have added a blank line. Please check. https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/mes... File ui/message_center/views/message_list_view.cc (right): https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/mes... ui/message_center/views/message_list_view.cc:5: #include "ui/message_center/views/message_list_view.h" On 2017/06/07 06:30:13, a.suchit2 wrote: > one empty line required after line 5. Done.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tripta.g@samsung.com changed reviewers: + derat@chromium.org, sadrul@chromium.org
Hi sadrul, Please review changes in following files: ui/message_center/views/message_list_view.cc ui/wm/core/shadow_controller.cc ui/wm/core/transient_window_manager.cc ui/wm/core/window_animations_unittest.cc Hi Daniel Erat, Please review changes in below file: ui/wm/core/shadow_controller.cc
lgtm w/nit https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_anima... File ui/wm/core/window_animations_unittest.cc (right): https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_anima... ui/wm/core/window_animations_unittest.cc:183: EXPECT_TRUE( nit: make this EXPECT_FALSE(base::ContainsValue(...
Have made the changes. Please check code. Thanks. https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_anima... File ui/wm/core/window_animations_unittest.cc (right): https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_anima... ui/wm/core/window_animations_unittest.cc:183: EXPECT_TRUE( On 2017/06/07 14:43:09, Daniel Erat wrote: > nit: make this EXPECT_FALSE(base::ContainsValue(... Done.
The CQ bit was checked by tripta.g@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org Link to the patchset: https://codereview.chromium.org/2926793002/#ps40001 (title: "Changed EXPECT_TRUE to EXPECT_FALSE")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by a.suchit@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tripta.g@samsung.com changed reviewers: + sadrul@google.com - a.suchit@chromium.org, a.suchit@samsung.com, derat@chromium.org
Hi sadrul,
Please review code changes for following files:
ui/message_center/views/message_list_view.cc
ui/wm/core/transient_window_manager.cc
ui/wm/core/window_animations_unittest.cc
Regards
Tripta
tripta.g@samsung.com changed reviewers: + a.suchit@chromium.org, a.suchit@samsung.com, derat@chromium.org
lgtm
The CQ bit was checked by a.suchit@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497236874765280,
"parent_rev": "b72c008d3c36bb39d9b13225b42f18aff0aa4c8e", "commit_rev":
"602d0022f1db92aa45aeed42a712f9eccc29ac8d"}
Message was sent while issue was closed.
Description was changed from ========== Use ContainsValue() instead of std::find() in ui/wm and ui/message_center BUG=561800 ========== to ========== Use ContainsValue() instead of std::find() in ui/wm and ui/message_center BUG=561800 Review-Url: https://codereview.chromium.org/2926793002 Cr-Commit-Position: refs/heads/master@{#478550} Committed: https://chromium.googlesource.com/chromium/src/+/602d0022f1db92aa45aeed42a712... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/602d0022f1db92aa45aeed42a712... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
