Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2926793002: Use ContainsValue() instead of std::find() in ui/wm and ui/message_center (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in ui/wm and ui/message_center BUG=561800 Review-Url: https://codereview.chromium.org/2926793002 Cr-Commit-Position: refs/heads/master@{#478550} Committed: https://chromium.googlesource.com/chromium/src/+/602d0022f1db92aa45aeed42a712f9eccc29ac8d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added a blank line. #

Total comments: 2

Patch Set 3 : Changed EXPECT_TRUE to EXPECT_FALSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M ui/message_center/views/message_list_view.cc View 1 4 chunks +5 lines, -8 lines 0 comments Download
M ui/wm/core/shadow_controller.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/wm/core/transient_window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/window_animations_unittest.cc View 1 2 3 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
Tripta
Please review the code changes
3 years, 6 months ago (2017-06-07 05:22:00 UTC) #3
a.suchit2
https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/message_list_view.cc File ui/message_center/views/message_list_view.cc (right): https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/message_list_view.cc#newcode5 ui/message_center/views/message_list_view.cc:5: #include "ui/message_center/views/message_list_view.h" one empty line required after line 5.
3 years, 6 months ago (2017-06-07 06:30:13 UTC) #5
Tripta
Have added a blank line. Please check. https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/message_list_view.cc File ui/message_center/views/message_list_view.cc (right): https://codereview.chromium.org/2926793002/diff/1/ui/message_center/views/message_list_view.cc#newcode5 ui/message_center/views/message_list_view.cc:5: #include "ui/message_center/views/message_list_view.h" ...
3 years, 6 months ago (2017-06-07 06:40:13 UTC) #6
Tripta
Hi sadrul, Please review changes in following files: ui/message_center/views/message_list_view.cc ui/wm/core/shadow_controller.cc ui/wm/core/transient_window_manager.cc ui/wm/core/window_animations_unittest.cc Hi Daniel Erat, ...
3 years, 6 months ago (2017-06-07 08:55:43 UTC) #12
Daniel Erat
lgtm w/nit https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_animations_unittest.cc File ui/wm/core/window_animations_unittest.cc (right): https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_animations_unittest.cc#newcode183 ui/wm/core/window_animations_unittest.cc:183: EXPECT_TRUE( nit: make this EXPECT_FALSE(base::ContainsValue(...
3 years, 6 months ago (2017-06-07 14:43:10 UTC) #13
Tripta
Have made the changes. Please check code. Thanks. https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_animations_unittest.cc File ui/wm/core/window_animations_unittest.cc (right): https://codereview.chromium.org/2926793002/diff/20001/ui/wm/core/window_animations_unittest.cc#newcode183 ui/wm/core/window_animations_unittest.cc:183: EXPECT_TRUE( ...
3 years, 6 months ago (2017-06-08 03:49:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926793002/40001
3 years, 6 months ago (2017-06-08 03:50:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/458662)
3 years, 6 months ago (2017-06-08 04:00:17 UTC) #19
Daniel Erat
lgtm
3 years, 6 months ago (2017-06-08 12:37:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926793002/40001
3 years, 6 months ago (2017-06-08 12:41:56 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/458911)
3 years, 6 months ago (2017-06-08 12:48:27 UTC) #24
Tripta
Hi sadrul, Please review code changes for following files: ui/message_center/views/message_list_view.cc ui/wm/core/transient_window_manager.cc ui/wm/core/window_animations_unittest.cc Regards Tripta
3 years, 6 months ago (2017-06-09 05:44:06 UTC) #26
sadrul
lgtm
3 years, 6 months ago (2017-06-12 01:59:46 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926793002/40001
3 years, 6 months ago (2017-06-12 03:08:00 UTC) #30
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 04:13:36 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/602d0022f1db92aa45aeed42a712...

Powered by Google App Engine
This is Rietveld 408576698