color: Enable color correct rendering on all layout tests

color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
R=enne
TBR=avi (content/)

Review-Url: https://codereview.chromium.org/2926763004
Cr-Commit-Position: refs/heads/master@{#478508}
Committed: https://chromium.googlesource.com/chromium/src/+/359e6112cc42d7ae7b055b413f16bce29b375bd5

[ccameron, 2017-06-09 17:05:23]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org, qyearsley@chromium.org

[ccameron, 2017-06-09 17:05:23]

FYI -- hoping to land this today.

Last I checked the only new failures were some WebGL-ImageBitmap failures (being
worked on in crbug.com/730983).

[enne (OOO), 2017-06-09 17:40:38]

Exciting!

lgtm

[qyearsley, 2017-06-09 17:41:23]

On 2017/06/09 17:05:23, ccameron wrote:
> FYI -- hoping to land this today.
> 
> Last I checked the only new failures were some WebGL-ImageBitmap failures
(being
> worked on in crbug.com/730983).

Alright, good news! Are you planning to fix crbug.com/730983 before landing
this?

Note there are about 30 mismatches on non-mac platforms, and about 210 failures
on mac platforms. I personally can't tell much of a difference between actual
and expected in any of the failing tests, so it's hard to tell whether the right
action is to rebaseline here. Should the current baselines all be correct or
will this CL require rebaselining?

[ccameron, 2017-06-09 18:03:43]

On 2017/06/09 17:41:23, qyearsley wrote:
> On 2017/06/09 17:05:23, ccameron wrote:
> > FYI -- hoping to land this today.
> > 
> > Last I checked the only new failures were some WebGL-ImageBitmap failures
> (being
> > worked on in crbug.com/730983).
> 
> Alright, good news! Are you planning to fix crbug.com/730983 before landing
> this?

That's going a bit back-and-forth in review, so I'm putting in a suppression --
hopefully I'll be able to land the fix and take out the suppression this
weekend.

> Note there are about 30 mismatches on non-mac platforms, and about 210
failures
> on mac platforms. I personally can't tell much of a difference between actual
> and expected in any of the failing tests, so it's hard to tell whether the
right
> action is to rebaseline here. Should the current baselines all be correct or
> will this CL require rebaselining?

The non-Mac mismatches are mostly from video now using color correction.

On Mac, we used to be using Apple's "generic RGB" profile, and now we're using
sRGB. The up-shot of this is that lots of blending and lots of images are
totally different than they used to be. The good news is that most of these
mac-specific-expected.png files will be removed and replaced with a
cross-platform-expected.png file.

[jfernandez, 2017-06-09 20:40:22]

Description was changed from

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
==========

to

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
==========

[ccameron, 2017-06-09 21:27:41]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 21:27:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-06-09 21:28:55]

Description was changed from

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
==========

to

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
R=enne
TBR=avi (content/)
==========

[commit-bot: I haz the power, 2017-06-09 23:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 23:04:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-06-09 23:12:53]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-06-09 23:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2926763004/#ps80001
(title: "Add timeout and one more suppression")

[commit-bot: I haz the power, 2017-06-09 23:13:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 00:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 00:49:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-06-10 02:51:28]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-06-10 02:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2926763004/#ps100001
(title: "One more expectations")

[commit-bot: I haz the power, 2017-06-10 02:51:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 04:15:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497063088994190,
"parent_rev": "ce6b8af7eda7b67005c57452ace88adbeeaadbdb", "commit_rev":
"359e6112cc42d7ae7b055b413f16bce29b375bd5"}

[commit-bot: I haz the power, 2017-06-10 04:16:11]

Description was changed from

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
R=enne
TBR=avi (content/)
==========

to

==========
color: Enable color correct rendering on all layout tests

Also make all platforms default to sRGB.

BUG=713891
R=enne
TBR=avi (content/)

Review-Url: https://codereview.chromium.org/2926763004
Cr-Commit-Position: refs/heads/master@{#478508}
Committed:
https://chromium.googlesource.com/chromium/src/+/359e6112cc42d7ae7b055b413f16...
==========

[commit-bot: I haz the power, 2017-06-10 04:16:13]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/359e6112cc42d7ae7b055b413f16...