Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2926733002: Get Help/HelpApp M61 release - manifest files (Closed)

Created:
3 years, 6 months ago by morsed
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, morsed1, cnwan, cylee
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get Help/HelpApp M61 release - manifest files Support Content API Migration Migrating both Get Help app and child HelpApp from old googleapis.com API to new support.google.com API. BUG=701953 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2926733002 Cr-Commit-Position: refs/heads/master@{#477454} Committed: https://chromium.googlesource.com/chromium/src/+/fdc621807ae9a6cc4b451472a5bf5225a6e2c1e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/genius_app/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/help_app/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
morsed1
Manifest files for Get Help app and child HelpApp ready for review.
3 years, 6 months ago (2017-06-06 22:43:56 UTC) #5
xiyuan
lgtm
3 years, 6 months ago (2017-06-06 22:44:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926733002/1
3 years, 6 months ago (2017-06-06 22:47:29 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 23:12:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdc621807ae9a6cc4b451472a5bf...

Powered by Google App Engine
This is Rietveld 408576698