Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2926713006:
Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. (Closed)
|
Created:
3 years, 6 months ago by peah Modified:
3 years, 6 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisabling logging of AEC metrics for AEC version 2 when AEC3 is active.
This CL ensures that the metrics for the WebRTC echo canceller version 2
are not logged when echo canceller version 3 is active
BUG=chromium:731283, chromium:731633
Review-Url: https://codereview.chromium.org/2926713006
Cr-Commit-Position: refs/heads/master@{#478252}
Committed: https://chromium.googlesource.com/chromium/src/+/eaeebae2cdd61180c7b3d82428620a9eb922b98d
Patch Set 1 #
Total comments: 4
Patch Set 2 : Changes in response to reviewer comments #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. BUG= ========== to ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. This CL ensures that the metrics for the WebRTC echo canceller version 2 are not logged when echo canceller version 3 is active BUG=chromium:731283 ==========
peah@chromium.org changed reviewers: + guidou@chromium.org, hlundin@chromium.org
guidou@ and hlundin@: Could you please take a look at this CL?
The CQ bit was checked by peah@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_audio_processor.cc:510: echo_information_.reset(new EchoInformation()); prefer base::MakeUnique to raw new. You can use assignment instead of reset in this case. https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_audio_processor.cc:714: echo_information_.reset(); ditto
On 2017/06/09 01:39:33, Guido Urdaneta wrote: > https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... > File content/renderer/media/media_stream_audio_processor.cc (right): > > https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... > content/renderer/media/media_stream_audio_processor.cc:510: > echo_information_.reset(new EchoInformation()); > prefer base::MakeUnique to raw new. > You can use assignment instead of reset in this case. > > https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... > content/renderer/media/media_stream_audio_processor.cc:714: > echo_information_.reset(); > ditto Thanks for the comments! I have uploaded a new patch with the suggested changes. PTAL!
lgtm
lgtm
https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_audio_processor.cc:510: echo_information_.reset(new EchoInformation()); On 2017/06/09 01:39:33, Guido Urdaneta wrote: > prefer base::MakeUnique to raw new. > You can use assignment instead of reset in this case. Done. https://codereview.chromium.org/2926713006/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_audio_processor.cc:714: echo_information_.reset(); On 2017/06/09 01:39:33, Guido Urdaneta wrote: > ditto Done.
Description was changed from ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. This CL ensures that the metrics for the WebRTC echo canceller version 2 are not logged when echo canceller version 3 is active BUG=chromium:731283 ========== to ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. This CL ensures that the metrics for the WebRTC echo canceller version 2 are not logged when echo canceller version 3 is active BUG=chromium:731283, chromium:731633 ==========
The CQ bit was checked by peah@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497006271556170,
"parent_rev": "5b373640b13e2f25ed1f48a1ad40edab67746f5e", "commit_rev":
"eaeebae2cdd61180c7b3d82428620a9eb922b98d"}
Message was sent while issue was closed.
Description was changed from ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. This CL ensures that the metrics for the WebRTC echo canceller version 2 are not logged when echo canceller version 3 is active BUG=chromium:731283, chromium:731633 ========== to ========== Disabling logging of AEC metrics for AEC version 2 when AEC3 is active. This CL ensures that the metrics for the WebRTC echo canceller version 2 are not logged when echo canceller version 3 is active BUG=chromium:731283, chromium:731633 Review-Url: https://codereview.chromium.org/2926713006 Cr-Commit-Position: refs/heads/master@{#478252} Committed: https://chromium.googlesource.com/chromium/src/+/eaeebae2cdd61180c7b3d8242862... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/eaeebae2cdd61180c7b3d8242862... |
