Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2926683003:
Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN (Closed)
|
Created:
3 years, 6 months ago by Qiang(Joe) Xu Modified:
3 years, 6 months ago Reviewers:
sky CC:
chromium-reviews, tfarina Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN
Changes:
This is a speculative fix of flakiness of
WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild.
WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix.
R=sky@chromium.org
BUG=729331
TEST=trybot tests
Review-Url: https://codereview.chromium.org/2926683003
Cr-Commit-Position: refs/heads/master@{#477754}
Committed: https://chromium.googlesource.com/chromium/src/+/81f90ea81c1e46f8e20f84e0449f397d19f809c8
Patch Set 1 #Patch Set 2 : change to the test coverage only #
Total comments: 2
Patch Set 3 : feedback #Messages
Total messages: 22 (14 generated)
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN BUG=729331 TEST=trybot tests ========== to ========== Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN Changes: This is a speculative fix of flakiness of WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild. WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix. R=sky@chromium.org BUG=729331 TEST=trybot tests ==========
warx@chromium.org changed reviewers: + sky@chromium.org
Hi sky@, PTAL thanks
https://codereview.chromium.org/2926683003/diff/40001/ui/views/widget/widget_... File ui/views/widget/widget_interactive_uitest.cc (right): https://codereview.chromium.org/2926683003/diff/40001/ui/views/widget/widget_... ui/views/widget/widget_interactive_uitest.cc:1279: #if defined(OS_WIN) I get that you really only need this for windows, but will it matter on other platforms? Can you always do it?
PTAL thanks https://codereview.chromium.org/2926683003/diff/40001/ui/views/widget/widget_... File ui/views/widget/widget_interactive_uitest.cc (right): https://codereview.chromium.org/2926683003/diff/40001/ui/views/widget/widget_... ui/views/widget/widget_interactive_uitest.cc:1279: #if defined(OS_WIN) On 2017/06/07 16:09:34, sky wrote: > I get that you really only need this for windows, but will it matter on other > platforms? Can you always do it? yes, we can always do it. Done.
LGTM
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496865816295450,
"parent_rev": "3abfb995607fad374795c7abd737c4d012e7d7b0", "commit_rev":
"81f90ea81c1e46f8e20f84e0449f397d19f809c8"}
Message was sent while issue was closed.
Description was changed from ========== Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN Changes: This is a speculative fix of flakiness of WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild. WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix. R=sky@chromium.org BUG=729331 TEST=trybot tests ========== to ========== Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN Changes: This is a speculative fix of flakiness of WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild. WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix. R=sky@chromium.org BUG=729331 TEST=trybot tests Review-Url: https://codereview.chromium.org/2926683003 Cr-Commit-Position: refs/heads/master@{#477754} Committed: https://chromium.googlesource.com/chromium/src/+/81f90ea81c1e46f8e20f84e0449f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/81f90ea81c1e46f8e20f84e0449f... |
