Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2926653003: Add Printing.CUPS.PrintersDiscovered to our metrics. (Closed)

Created:
3 years, 6 months ago by skau
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Add Printing.CUPS.PrintersDiscovered to our metrics. In order to understand how many printers users are seeing in the discovered printers dialog, track it using UMA. The metric is recorded when the discoverer declares scanning to be complete. BUG=726819 Review-Url: https://codereview.chromium.org/2904243003 Cr-Original-Commit-Position: refs/heads/master@{#475649} Review-Url: https://codereview.chromium.org/2926653003 . Cr-Commit-Position: refs/branch-heads/3112@{#207} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c86d7012ddedff5dd300906c9ec1ce9bccc9aae3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/browser/chromeos/printing/printer_discoverer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/printing/printer_discoverer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
skau
3 years, 6 months ago (2017-06-06 21:13:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c86d7012ddedff5dd300906c9ec1ce9bccc9aae3.

Powered by Google App Engine
This is Rietveld 408576698