Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2926643004: [MD settings] layout of buttons inside toggles and iron-lists (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG=728493, 728490, 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Original-Commit-Position: refs/heads/master@{#476699} Review-Url: https://codereview.chromium.org/2926643004 . Cr-Commit-Position: refs/branch-heads/3112@{#236} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3235d6e5d9211b5569d3a606b428c5cf98359cf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
dschuyler
3 years, 6 months ago (2017-06-07 21:06:15 UTC) #1
Description was changed from

==========
[MD settings] layout of buttons inside toggles and iron-lists

My prior CL 2902363002 did not properly account for buttons inside of
iron-lists (which will render poorly if overflow is visible, and clip off
ripples if overflow is visible); and buttons inside of toggle-buttons.
This CL addresses those gaps.

BUG=728493, 728490, 728487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918953002
Cr-Commit-Position: refs/heads/master@{#476699}
(cherry picked from commit f60d062aad6f02456fb50f4f5d00936d47d08030)
==========

to

==========
[MD settings] layout of buttons inside toggles and iron-lists

My prior CL 2902363002 did not properly account for buttons inside of
iron-lists (which will render poorly if overflow is visible, and clip off
ripples if overflow is visible); and buttons inside of toggle-buttons.
This CL addresses those gaps.

BUG=728493, 728490, 728487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918953002
Cr-Original-Commit-Position: refs/heads/master@{#476699}
Review-Url: https://codereview.chromium.org/2926643004 .
Cr-Commit-Position: refs/branch-heads/3112@{#236}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/3235d6e5d9211b5569d3a606b428...
==========

Powered by Google App Engine
This is Rietveld 408576698