Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: tools/perf/page_sets/tough_ad_cases.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/top_25_smooth.py ('k') | tools/perf/page_sets/tough_animation_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_ad_cases.py
diff --git a/tools/perf/page_sets/tough_ad_cases.py b/tools/perf/page_sets/tough_ad_cases.py
index cf9635739fdb4bc5f75609d0e8b8b6a538970675..f1748d017b5b70fb854c0a0eb28c6c12a6dc07fd 100644
--- a/tools/perf/page_sets/tough_ad_cases.py
+++ b/tools/perf/page_sets/tough_ad_cases.py
@@ -13,7 +13,8 @@ class SwiffyPage(page_module.Page):
def __init__(self, url, page_set):
super(SwiffyPage, self).__init__(url=url, page_set=page_set,
- make_javascript_deterministic=False)
+ make_javascript_deterministic=False,
+ name=url)
def RunNavigateSteps(self, action_runner):
super(SwiffyPage, self).RunNavigateSteps(action_runner)
@@ -42,13 +43,17 @@ class AdPage(page_module.Page):
y_scroll_distance_multiplier=0.5,
scroll=False,
wait_for_interactive_or_better=False):
+ name = url
+ if not name.startswith('http'):
+ name = url.split('/')[-1]
super(AdPage, self).__init__(
url=url,
page_set=page_set,
make_javascript_deterministic=make_javascript_deterministic,
shared_page_state_class=(
repeatable_synthesize_scroll_gesture_shared_state.\
- RepeatableSynthesizeScrollGestureSharedState))
+ RepeatableSynthesizeScrollGestureSharedState),
+ name=name)
self._y_scroll_distance_multiplier = y_scroll_distance_multiplier
self._scroll = scroll
self._wait_for_interactive_or_better = wait_for_interactive_or_better
@@ -114,7 +119,8 @@ class SyntheticToughAdCasesPageSet(story.StorySet):
def __init__(self):
super(SyntheticToughAdCasesPageSet, self).__init__(
archive_data_file='data/tough_ad_cases.json',
- cloud_storage_bucket=story.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET,
+ verify_names=True)
base_url = 'http://localhost:8000'
@@ -144,7 +150,8 @@ class SyntheticToughWebglAdCasesPageSet(story.StorySet):
def __init__(self):
super(SyntheticToughWebglAdCasesPageSet, self).__init__(
archive_data_file='data/tough_ad_cases.json',
- cloud_storage_bucket=story.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET,
+ verify_names=True)
base_url = 'http://localhost:8000'
@@ -174,7 +181,8 @@ class ToughAdCasesPageSet(story.StorySet):
def __init__(self, scroll=False):
super(ToughAdCasesPageSet, self).__init__(
archive_data_file='data/tough_ad_cases.json',
- cloud_storage_bucket=story.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET,
+ verify_names=True)
self.AddStory(AdPage('file://tough_ad_cases/'
'swiffy_collection.html', self, make_javascript_deterministic=False,
« no previous file with comments | « tools/perf/page_sets/top_25_smooth.py ('k') | tools/perf/page_sets/tough_animation_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698