Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: tools/perf/page_sets/top_25_smooth.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/simple_mobile_sites.py ('k') | tools/perf/page_sets/tough_ad_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/top_25_smooth.py
diff --git a/tools/perf/page_sets/top_25_smooth.py b/tools/perf/page_sets/top_25_smooth.py
index f327ff1af95bcca1830a3cd7eaa07cc25e3e685b..ad730957cb3fb00d05718cbb970fd5b9f2e5bb7c 100644
--- a/tools/perf/page_sets/top_25_smooth.py
+++ b/tools/perf/page_sets/top_25_smooth.py
@@ -26,6 +26,8 @@ def _CreatePageClassWithSmoothInteractions(page_cls):
class TopSmoothPage(page_module.Page):
def __init__(self, url, page_set, name='', credentials=None):
+ if name == '':
+ name = url
super(TopSmoothPage, self).__init__(
url=url, page_set=page_set, name=name,
shared_page_state_class=shared_page_state.SharedDesktopPageState,
@@ -112,7 +114,8 @@ class Top25SmoothPageSet(story.StorySet):
def __init__(self, techcrunch=True):
super(Top25SmoothPageSet, self).__init__(
archive_data_file='data/top_25_smooth.json',
- cloud_storage_bucket=story.PARTNER_BUCKET)
+ cloud_storage_bucket=story.PARTNER_BUCKET,
+ verify_names=True)
desktop_state_class = shared_page_state.SharedDesktopPageState
« no previous file with comments | « tools/perf/page_sets/simple_mobile_sites.py ('k') | tools/perf/page_sets/tough_ad_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698