Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: media/gpu/h264_decoder.h

Issue 2926593002: V4L2SVDA/VAAPIVDA: use visible size from decoder and pass to client (Closed)
Patch Set: V4L2SVDA/VAAPIVDA: use visible size from decoder and pass to client Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/gpu/h264_decoder.cc » ('j') | media/gpu/vp8_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/h264_decoder.h
diff --git a/media/gpu/h264_decoder.h b/media/gpu/h264_decoder.h
index 1caf662a7a6fa07b68b069321e014195fd6f28fd..7daffc7ed43bcca4da022003a3c8e04d5d55596e 100644
--- a/media/gpu/h264_decoder.h
+++ b/media/gpu/h264_decoder.h
@@ -18,6 +18,7 @@
#include "media/gpu/accelerated_video_decoder.h"
#include "media/gpu/h264_dpb.h"
#include "media/gpu/media_gpu_export.h"
+#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
namespace media {
@@ -90,7 +91,8 @@ class MEDIA_GPU_EXPORT H264Decoder : public AcceleratedVideoDecoder {
// as this method was called for them. Decoder may drop its reference
// to |pic| after calling this method.
// Return true if successful.
- virtual bool OutputPicture(const scoped_refptr<H264Picture>& pic) = 0;
+ virtual bool OutputPicture(const scoped_refptr<H264Picture>& pic,
+ const gfx::Rect& visible_rect) = 0;
Pawel Osciak 2017/06/08 04:58:24 Please document |visible_rect| (especially the mea
johnylin1 2017/06/12 13:41:53 This is removed in newer patch, I document visible
// Reset any current state that may be cached in the accelerator, dropping
// any cached parameters/slices that have not been committed yet.
@@ -266,6 +268,8 @@ class MEDIA_GPU_EXPORT H264Decoder : public AcceleratedVideoDecoder {
// Output picture size.
gfx::Size pic_size_;
+ // Output visible cropping rect.
+ gfx::Rect visible_rect_;
// PicOrderCount of the previously outputted frame.
int last_output_poc_;
« no previous file with comments | « no previous file | media/gpu/h264_decoder.cc » ('j') | media/gpu/vp8_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698