V4L2SVDA/VAAPIVDA: use visible size from decoder and pass to client

media/gpu/h264_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_GPU_H264_DECODER_H_
 #define MEDIA_GPU_H264_DECODER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "media/base/limits.h"
 #include "media/filters/h264_parser.h"
 #include "media/gpu/accelerated_video_decoder.h"
 #include "media/gpu/h264_dpb.h"
 #include "media/gpu/media_gpu_export.h"
+#include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace media {
 
 // Clients of this class are expected to pass H264 Annex-B byte stream
 // and are expected to provide an implementation of H264Accelerator for
 // offloading final steps of the decoding process.
 //
 // This class must be created, called and destroyed on a single thread, and
 // does nothing internally on any other thread.
@@ skipping 52 matching lines @@
     // the previous call to SubmitDecode().
     // Return true if successful.
     virtual bool SubmitDecode(const scoped_refptr<H264Picture>& pic) = 0;
 
     // Schedule output (display) of |pic|. Note that returning from this
     // method does not mean that |pic| has already been outputted (displayed),
     // but guarantees that all pictures will be outputted in the same order
     // as this method was called for them. Decoder may drop its reference
     // to |pic| after calling this method.
     // Return true if successful.
-    virtual bool OutputPicture(const scoped_refptr<H264Picture>& pic) = 0;
+    virtual bool OutputPicture(const scoped_refptr<H264Picture>& pic,
+                               const gfx::Rect& visible_rect) = 0;

[Pawel Osciak, 2017/06/08 04:58:24]

Please document |visible_rect| (especially the meaning of 0,0).

[johnylin1, 2017/06/12 13:41:53]

This is removed in newer patch, I document visible_rect in H264/VP8/VP9Picture
instead.

 
     // Reset any current state that may be cached in the accelerator, dropping
     // any cached parameters/slices that have not been committed yet.
     virtual void Reset() = 0;
 
    private:
     DISALLOW_COPY_AND_ASSIGN(H264Accelerator);
   };
 
   H264Decoder(H264Accelerator* accelerator);
@@ skipping 155 matching lines @@
   // Currently active SPS and PPS.
   int curr_sps_id_;
   int curr_pps_id_;
 
   // Current NALU and slice header being processed.
   std::unique_ptr<H264NALU> curr_nalu_;
   std::unique_ptr<H264SliceHeader> curr_slice_hdr_;
 
   // Output picture size.
   gfx::Size pic_size_;
+  // Output visible cropping rect.
+  gfx::Rect visible_rect_;
 
   // PicOrderCount of the previously outputted frame.
   int last_output_poc_;
 
   H264Accelerator* accelerator_;
 
   DISALLOW_COPY_AND_ASSIGN(H264Decoder);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_GPU_H264_DECODER_H_