Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2926563005: [GRC] Correctly Invalidate RenderProcessHost's CU Interface (Closed)

Created:
3 years, 6 months ago by matthalp
Modified:
3 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[GRC] Correctly Invalidate RenderProcessHost's CU Interface The RenderProcessHost CoordinationUnitInterface currently does not remain up-to-date with when the RenderProcessHosts's RenderProcess changes -- specifically when the RenderProcess dies. This CL addresses the problem by invalidating the RenderProcessHosts's CoordinationUnitInterface when it detects the RenderProcess has died. Additionally checks have been made to make sure the RenderProcess is valid. R=oysteine@chromium.org,nasko@chromium.org BUG=724306 Review-Url: https://codereview.chromium.org/2926563005 Cr-Commit-Position: refs/heads/master@{#478467} Committed: https://chromium.googlesource.com/chromium/src/+/e5ea152d0b65df17dcf3aa72cd7a3fc734f94495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
matthalp
3 years, 6 months ago (2017-06-08 18:16:09 UTC) #6
oystein (OOO til 10th of July)
lgtm
3 years, 6 months ago (2017-06-08 18:17:01 UTC) #7
nasko
LGTM
3 years, 6 months ago (2017-06-09 22:22:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926563005/1
3 years, 6 months ago (2017-06-09 22:24:27 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 23:58:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5ea152d0b65df17dcf3aa72cd7a...

Powered by Google App Engine
This is Rietveld 408576698