DevTools: check BUILD.gn file as part of PRESUBMIT

DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js (a 104kb file) in the Chrome binary.

BUG=729646
Review-Url: https://codereview.chromium.org/2926563004
Cr-Commit-Position: refs/heads/master@{#478125}
Committed: https://chromium.googlesource.com/chromium/src/+/ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c

[chenwilliam, 2017-06-08 00:47:27]

Description was changed from

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js in the Chrome binary. This should
save 104kb!

BUG=729646
==========

to

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js in the Chrome binary. This should
save ~104kb!

BUG=729646
==========

[chenwilliam, 2017-06-08 00:48:09]

Description was changed from

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js in the Chrome binary. This should
save ~104kb!

BUG=729646
==========

to

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js (a 104kb file) in the Chrome binary.

BUG=729646
==========

[chenwilliam, 2017-06-08 00:52:16]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2017-06-08 00:52:17]

ptal

[dgozman, 2017-06-08 18:21:38]

lgtm

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/check_gn.js (right):

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/check_gn.js:8: const
inspectorManifest = require('../front_end/inspector.json');
Should we check all apps?

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/check_gn.js:59: for (var i = 0; i <
gnLines.length; i++) {
let!

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/check_gn.js:71: return selection;
let lines = gnLines.map(line => line.trim())
let startIndex = lines.indexOf(startLine);
if (startIndex === -1) return [];
let endIndex = linex.indexOf(endLine, startIndex);
if (endIndex === -1) endIndex = lines.length;
return lines.slice(startIndex, endIndex);

[chenwilliam, 2017-06-08 18:49:04]

thanks for the review.

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/check_gn.js (right):

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/check_gn.js:8: const
inspectorManifest = require('../front_end/inspector.json');
On 2017/06/08 18:21:37, dgozman wrote:
> Should we check all apps?

Let's do it in a f/u CL. I'd like to create validations for remote modules,
input files, etc. similar to this.

https://codereview.chromium.org/2926563004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/check_gn.js:71: return selection;
On 2017/06/08 18:21:37, dgozman wrote:
> let lines = gnLines.map(line => line.trim())
> let startIndex = lines.indexOf(startLine);
> if (startIndex === -1) return [];
> let endIndex = linex.indexOf(endLine, startIndex);
> if (endIndex === -1) endIndex = lines.length;
> return lines.slice(startIndex, endIndex);

done. slight modification so if endIndex is not found it returns [] (I want the
script to be conservative and fail in this case);

[chenwilliam, 2017-06-08 18:49:09]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-06-08 18:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2926563004/#ps20001
(title: "fixup")

[commit-bot: I haz the power, 2017-06-08 18:50:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 23:53:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496947749952780,
"parent_rev": "4dc68137b9724480cf6e055d24cbff75458a114e", "commit_rev":
"ed6ec852ac94bcd64f7a9b7fb279916adb1cf22c"}

[commit-bot: I haz the power, 2017-06-08 23:53:37]

Description was changed from

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js (a 104kb file) in the Chrome binary.

BUG=729646
==========

to

==========
DevTools: check BUILD.gn file as part of PRESUBMIT

This PRESUBMIT check only takes ~0.12 seconds on my workstation.

It actually caught a real issue with our existing BUILD.gn as it accidentally
included the generated terminal_module.js (a 104kb file) in the Chrome binary.

BUG=729646

Review-Url: https://codereview.chromium.org/2926563004
Cr-Commit-Position: refs/heads/master@{#478125}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed6ec852ac94bcd64f7a9b7fb279...
==========

[commit-bot: I haz the power, 2017-06-08 23:53:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed6ec852ac94bcd64f7a9b7fb279...