chromeos: Replace "/tmp" with a call to PathService::Get()

chromeos: Replace "/tmp" with a call to PathService::Get()

This is in preparation for adding a browser test that is to
ensure access control for file:scheme is working. In the
browser test, I plan to use PathService::Get(DIR_TEMP) to
store a symbolic link in a location that's accessible via file:
scheme.

Confirmed that PathService::Get(DIR_TEMP) returns /tmp in
production so this patch does not change the production
behavior.

Along the way, simplify the code a bit by introducing a vector.

TEST=file:///tmp is still accessible on a Chromebook
BUG=677933
Review-Url: https://codereview.chromium.org/2926543002
Cr-Commit-Position: refs/heads/master@{#477885}
Committed: https://chromium.googlesource.com/chromium/src/+/ca8b564942b90a8ce527933dca71645880e214ab

[satorux1, 2017-06-06 08:15:49]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 08:16:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[satorux1, 2017-06-06 08:19:04]

satorux@chromium.org changed reviewers:
+ mmenke@chromium.org

[satorux1, 2017-06-06 08:19:05]

PTAL

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
chrome/browser/net/chrome_network_delegate.cc:484:
"/home/chronos/user/Downloads",
tried to replace this with DIR_DEFAULT_DOWNLOADS or DIR_DEFAULT_DOWNLOADS_SAFE
but didn't work. In production these constants are mapped to:

DIR_DEFAULT_DOWNLOADS => /home/chronos/user
DIR_DEFAULT_DOWNLOADS_SAFE => /home/chronos/u-<hash>/Downloads

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
chrome/browser/net/chrome_network_delegate.cc:517: "/sdcard", "/mnt/sdcard",
by clang format.

[commit-bot: I haz the power, 2017-06-06 09:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 09:07:43]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-06-06 15:49:08]

LGTM

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
chrome/browser/net/chrome_network_delegate.cc:521: for (size_t i = 0; i <
arraysize(kLocalAccessWhiteList); ++i)
optional:  Could switch this to something like "for (const auto& path :
kLocalAccessWhiteList)"

[satorux1, 2017-06-08 02:11:05]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 02:11:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[satorux1, 2017-06-08 02:13:44]

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://codereview.chromium.org/2926543002/diff/1/chrome/browser/net/chrome_n...
chrome/browser/net/chrome_network_delegate.cc:521: for (size_t i = 0; i <
arraysize(kLocalAccessWhiteList); ++i)
On 2017/06/06 15:49:07, mmenke wrote:
> optional:  Could switch this to something like "for (const auto& path :
> kLocalAccessWhiteList)"

Done.

[satorux1, 2017-06-08 02:18:26]

Patchset #2 (id:20001) has been deleted

[satorux1, 2017-06-08 02:19:00]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 02:19:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 04:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 04:19:46]

Dry run: This issue passed the CQ dry run.

[satorux1, 2017-06-08 04:21:55]

The CQ bit was checked by satorux@chromium.org

[satorux1, 2017-06-08 04:21:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2926543002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-06-08 04:22:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 04:26:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496895715320940,
"parent_rev": "feae432eb3cfeafbd4c30795171ac46462a23c80", "commit_rev":
"ca8b564942b90a8ce527933dca71645880e214ab"}

[commit-bot: I haz the power, 2017-06-08 04:26:47]

Description was changed from

==========
chromeos: Replace "/tmp" with a call to PathService::Get()

This is in preparation for adding a browser test that is to
ensure access control for file:scheme is working. In the
browser test, I plan to use PathService::Get(DIR_TEMP) to
store a symbolic link in a location that's accessible via file:
scheme.

Confirmed that PathService::Get(DIR_TEMP) returns /tmp in
production so this patch does not change the production
behavior.

Along the way, simplify the code a bit by introducing a vector.

TEST=file:///tmp is still accessible on a Chromebook
BUG=677933
==========

to

==========
chromeos: Replace "/tmp" with a call to PathService::Get()

This is in preparation for adding a browser test that is to
ensure access control for file:scheme is working. In the
browser test, I plan to use PathService::Get(DIR_TEMP) to
store a symbolic link in a location that's accessible via file:
scheme.

Confirmed that PathService::Get(DIR_TEMP) returns /tmp in
production so this patch does not change the production
behavior.

Along the way, simplify the code a bit by introducing a vector.

TEST=file:///tmp is still accessible on a Chromebook
BUG=677933

Review-Url: https://codereview.chromium.org/2926543002
Cr-Commit-Position: refs/heads/master@{#477885}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca8b564942b90a8ce527933dca71...
==========

[commit-bot: I haz the power, 2017-06-08 04:26:49]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca8b564942b90a8ce527933dca71...