Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2926513003: Use PaintImage in cc QueueImageDecode

Created:
3 years, 6 months ago by sohan
Modified:
3 years, 6 months ago
Reviewers:
vmpstr, Khushal
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, kinuko+watch, blink-reviews-html_chromium.org, jam, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, blink-reviews-frames_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PaintImage in cc QueueImageDecode This replaces current SKImage usage in QueueImageDecode and helps setting up the right PaintImage ID to be used in decode queue/cache. BUG=722559, 695108 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M cc/tiles/checker_image_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/checker_image_tracker_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/decoded_image_tracker.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/decoded_image_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/image_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/image_controller.cc View 1 2 chunks +5 lines, -9 lines 0 comments Download
M cc/tiles/image_controller_unittest.cc View 1 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vmpstr
Hmm. This is conflating a few different patches together I think. I actually was working ...
3 years, 6 months ago (2017-06-06 18:00:09 UTC) #3
sohanjg_
On 2017/06/06 18:00:09, vmpstr wrote: > Hmm. This is conflating a few different patches together ...
3 years, 6 months ago (2017-06-06 18:17:28 UTC) #4
sohan
Please take a look, thanks.
3 years, 6 months ago (2017-06-07 13:35:09 UTC) #9
Khushal
On 2017/06/07 13:35:09, sohan wrote: > Please take a look, thanks. Thanks for taking this ...
3 years, 6 months ago (2017-06-07 18:30:39 UTC) #12
sohan
3 years, 6 months ago (2017-06-08 01:24:48 UTC) #13
On 2017/06/07 18:30:39, Khushal wrote:
> On 2017/06/07 13:35:09, sohan wrote:
> > Please take a look, thanks.
> 
> Thanks for taking this up Sohan. But I already had to make that interface take
a
> DrawImage in order to scale it here:
> https://codereview.chromium.org/2928433003/. :(

Ahh i see..sorry for the confusion :/

Powered by Google App Engine
This is Rietveld 408576698