Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2926493002: Upstream position: sticky tests for script insertion and layout to WPT (Closed)

Created:
3 years, 6 months ago by smcgruer
Modified:
3 years, 6 months ago
Reviewers:
flackr, yigu, waxmiguel
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream position: sticky tests for script insertion and layout to WPT BUG=699244 Review-Url: https://codereview.chromium.org/2926493002 Cr-Commit-Position: refs/heads/master@{#481536} Committed: https://chromium.googlesource.com/chromium/src/+/a2d610c5c1b83d70c9eac38f45e683a88c9cd9f8

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address reviwer comments #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Messages

Total messages: 28 (20 generated)
smcgruer
3 years, 6 months ago (2017-06-05 22:49:43 UTC) #6
yigu
lgtm with nits https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html File third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html (right): https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html#newcode80 third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html:80: <div id="spacer3" class="spacer"></div> nits: Unused id ...
3 years, 6 months ago (2017-06-06 21:32:01 UTC) #7
flackr
https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html File third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html (right): https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html#newcode69 third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html:69: scroller.insertBefore(sticky, document.getElementById('spacer2')); perhaps even better than giving it an ...
3 years, 6 months ago (2017-06-07 18:32:56 UTC) #8
smcgruer
https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html File third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html (right): https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html#newcode69 third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-get-bounding-client-rect.html:69: scroller.insertBefore(sticky, document.getElementById('spacer2')); On 2017/06/07 18:32:56, flackr wrote: > perhaps ...
3 years, 6 months ago (2017-06-07 20:57:32 UTC) #9
flackr
LGTM, I could go either way on whether the test cases are shared. https://codereview.chromium.org/2926493002/diff/1/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-offset-top-left.html File ...
3 years, 6 months ago (2017-06-08 19:38:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926493002/60001
3 years, 6 months ago (2017-06-22 13:52:25 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/a2d610c5c1b83d70c9eac38f45e683a88c9cd9f8
3 years, 6 months ago (2017-06-22 15:12:57 UTC) #26
waxmiguel
3 years, 6 months ago (2017-06-22 16:19:59 UTC) #28
Message was sent while issue was closed.
burden

Powered by Google App Engine
This is Rietveld 408576698