Mac Archive Type Sniffing

chrome/browser/BUILD.gn

Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 1c6ccebcdd6f0e7e7c44d870604a6b2cf2a9aeb8..36a0f57b1db5bd9363ac870e4643fdd7b1235190 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -2400,6 +2400,12 @@ split_static_library("browser") {
         "safe_browsing/v4_test_utils.cc",
         "safe_browsing/v4_test_utils.h",
       ]
+      if (is_mac) {

[Robert Sesek, 2017/06/14 15:11:43]

You can drop this and just include it in the sources list directly (since the
filename exclusion will handle the platform condition for you).

[mortonm, 2017/06/14 17:13:15]

Done.

+        sources += [
+          "safe_browsing/disk_image_type_sniffer_mac.cc",

[vakh (use Gerrit instead), 2017/06/14 00:53:07]

Optional but recommended: Add a target for disk_image_type_sniffer in
chrome/browser/safe_browsing/BUILD.gn and make that a dependency here.

Ideally we should have done that for all the files in c/b/safe_browsing/ from
the start and you are certainly following a precedent so I won't block you on
this.

[mortonm, 2017/06/14 17:13:15]

Ok, sounds good. I'm not too familiar with the semantics of build files and what
to add in chrome/browser/safe_browsing/BUILD.gn, but I will try to make the
change before the code is finally submitted.

+          "safe_browsing/disk_image_type_sniffer_mac.h",
+        ]
+      }
       deps += [ "//components/safe_browsing_db:safe_browsing_db" ]
       if (is_win) {
         deps += [ "//chrome/browser/safe_browsing/incident_reporting:state_store_data_proto" ]