Mac Archive Type Sniffing

chrome/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 2382 matching lines @@
         "safe_browsing/sandboxed_zip_analyzer.h",
         "safe_browsing/services_delegate_impl.cc",
         "safe_browsing/services_delegate_impl.h",
         "safe_browsing/signature_evaluator_mac.h",
         "safe_browsing/signature_evaluator_mac.mm",
         "safe_browsing/two_phase_uploader.cc",
         "safe_browsing/two_phase_uploader.h",
         "safe_browsing/v4_test_utils.cc",
         "safe_browsing/v4_test_utils.h",
       ]
+      if (is_mac) {

[Robert Sesek, 2017/06/14 15:11:43]

You can drop this and just include it in the sources list directly (since the
filename exclusion will handle the platform condition for you).

[mortonm, 2017/06/14 17:13:15]

Done.

+        sources += [
+          "safe_browsing/disk_image_type_sniffer_mac.cc",

[vakh (use Gerrit instead), 2017/06/14 00:53:07]

Optional but recommended: Add a target for disk_image_type_sniffer in
chrome/browser/safe_browsing/BUILD.gn and make that a dependency here.

Ideally we should have done that for all the files in c/b/safe_browsing/ from
the start and you are certainly following a precedent so I won't block you on
this.

[mortonm, 2017/06/14 17:13:15]

Ok, sounds good. I'm not too familiar with the semantics of build files and what
to add in chrome/browser/safe_browsing/BUILD.gn, but I will try to make the
change before the code is finally submitted.

+          "safe_browsing/disk_image_type_sniffer_mac.h",
+        ]
+      }
       deps += [ "//components/safe_browsing_db:safe_browsing_db" ]
       if (is_win) {
         deps += [ "//chrome/browser/safe_browsing/incident_reporting:state_store_data_proto" ]
       }
     } else if (safe_browsing_mode == 2) {
       sources += [
         "loader/safe_browsing_resource_throttle.cc",
         "loader/safe_browsing_resource_throttle.h",
         "safe_browsing/services_delegate_stub.cc",
         "safe_browsing/services_delegate_stub.h",
@@ skipping 2368 matching lines @@
       "//components/search_engines",
       "//rlz:rlz_lib",
     ]
   }
 }
 
 service_manifest("preferences_forwarder_manifest") {
   name = "preferences_forwarder"
   source = "prefs/forwarder_manifest.json"
 }