Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2926403002: Restrict SW Renderer clear to scissor (Closed)

Created:
3 years, 6 months ago by ericrk
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Restrict SW Renderer clear to scissor The refactoring in crrev.com/2867913002 did not correctly handle cases where we cleared with a scissor active. This change ensures that the clear only applies to the scissored pixels. Bug: 729363 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1be4e55b112ddf3291c1883fccf1084dc0c90f79 Reviewed-on: https://chromium-review.googlesource.com/526301 Reviewed-by: enne <enne@chromium.org>; Commit-Queue: Eric Karl <ericrk@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477453} Review-Url: https://codereview.chromium.org/2926403002 . Cr-Commit-Position: refs/branch-heads/3112@{#269} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2ac3185caec2f97ef777b48f6b54dd83d58157a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M cc/output/software_renderer.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
3 years, 6 months ago (2017-06-08 21:44:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ac3185caec2f97ef777b48f6b54dd83d58157a4.

Powered by Google App Engine
This is Rietveld 408576698