Issue 29263004: Add support for reading non-rendertarget textures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29263004: Add support for reading non-rendertarget textures. (Closed)

Created:
7 years, 2 months ago by jvanverth1

Modified:
7 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add support for reading non-rendertarget textures. Also removes rendertarget flag from GrAtlas texture creation (no longer needed) and re-enables GrFontCache::dump(). Committed: http://code.google.com/p/skia/source/detail?r=11917

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Total comments: 1

Patch Set 3 : Fix nit. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
M	src/gpu/GrAtlas.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	2 chunks	+21 lines, -1 line	0 comments	Download
M	src/gpu/GrTextStrike.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 nit https://codereview.chromium.org/29263004/diff/20001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/29263004/diff/20001/src/gpu/GrContext.cpp#newcode1260 src/gpu/GrContext.cpp:1260: GrTexture* dst = ast.texture(); NULL ...

7 years, 2 months ago (2013-10-18 18:19:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/29263004/110001

7 years, 2 months ago (2013-10-23 15:18:42 UTC) #3

Message was sent while issue was closed.

Change committed as 11917

Expand Messages | Collapse Messages