MD Bookmarks: Add right-click context menu to sidebar folders

chrome/browser/resources/md_bookmarks/folder_node.js

Index: chrome/browser/resources/md_bookmarks/folder_node.js
diff --git a/chrome/browser/resources/md_bookmarks/folder_node.js b/chrome/browser/resources/md_bookmarks/folder_node.js
index a3fc65806de5b0d4bdb58c6019347be16e9c90d9..9b130bdde5067e23d9ce8b13db0b0ace89809b77 100644
--- a/chrome/browser/resources/md_bookmarks/folder_node.js
+++ b/chrome/browser/resources/md_bookmarks/folder_node.js
@@ -256,7 +256,18 @@ Polymer({
   /** @private */
   selectFolder_: function() {
     this.dispatch(
-        bookmarks.actions.selectFolder(this.item_.id, this.getState().nodes));
+        bookmarks.actions.selectFolder(this.itemId, this.getState().nodes));
+  },
+
+  /**
+   * @param {!Event} e
+   * @private
+   */
+  onContextMenu_: function(e) {
+    e.preventDefault();
+    this.selectFolder_();

[calamity, 2017/06/13 05:54:25]

This clears the current selection in the list. Is this intentional?

[tsergeant, 2017/06/13 07:01:54]

Yeah, this is intentional (and matches the old BMM).

I was finding that the context menu felt really contextless if we didn't change
the selected folder to match what was clicked.

[calamity, 2017/06/15 03:48:52]

Sorry, I mean it clears the current selection in the list even if it's the same
folder.

[tsergeant, 2017/06/15 05:50:26]

Ah, I see. This was a problem with just left-clicking the node as well.

Fixed.

+    bookmarks.CommandManager.getInstance().openCommandMenuAtPosition(
+        e.clientX, e.clientY, new Set([this.itemId]));
   },
 
   /**
@@ -274,7 +285,7 @@ Polymer({
    */
   toggleFolder_: function(e) {
     this.dispatch(
-        bookmarks.actions.changeFolderOpen(this.item_.id, this.isClosed_));
+        bookmarks.actions.changeFolderOpen(this.itemId, this.isClosed_));
     e.stopPropagation();
   },