MD Bookmarks: Add right-click context menu to sidebar folders

MD Bookmarks: Add right-click context menu to sidebar folders

Right clicking a folder in the sidebar will select that folder and
show the menu of edit/open commands for that folder.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2926233002
Cr-Commit-Position: refs/heads/master@{#479957}
Committed: https://chromium.googlesource.com/chromium/src/+/a274e041953915ac3c48d4bbb1c6d360253bffba

[tsergeant, 2017-06-08 01:19:24]

Description was changed from

==========
MD Bookmarks: Add right-click context menu to sidebar folders

Right clicking a folder in the sidebar will select that folder and
show the menu of edit/open commands for that folder.

BUG=692837
==========

to

==========
MD Bookmarks: Add right-click context menu to sidebar folders

Right clicking a folder in the sidebar will select that folder and
show the menu of edit/open commands for that folder.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-08 01:19:43]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 01:20:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 03:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 03:24:18]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-06-08 23:57:21]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2017-06-13 05:54:25]

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/command_manager.js:89: * Commands will
execute on the currently selected items.
Update comment.

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/folder_node.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/folder_node.js:268: this.selectFolder_();
This clears the current selection in the list. Is this intentional?

[tsergeant, 2017-06-13 07:01:54]

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/command_manager.js:89: * Commands will
execute on the currently selected items.
On 2017/06/13 05:54:25, calamity wrote:
> Update comment.

Done.

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/folder_node.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/folder_node.js:268: this.selectFolder_();
On 2017/06/13 05:54:25, calamity wrote:
> This clears the current selection in the list. Is this intentional?

Yeah, this is intentional (and matches the old BMM).

I was finding that the context menu felt really contextless if we didn't change
the selected folder to match what was clicked.

[calamity, 2017-06-15 03:48:52]

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/folder_node.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/folder_node.js:268: this.selectFolder_();
On 2017/06/13 07:01:54, tsergeant wrote:
> On 2017/06/13 05:54:25, calamity wrote:
> > This clears the current selection in the list. Is this intentional?
> 
> Yeah, this is intentional (and matches the old BMM).
> 
> I was finding that the context menu felt really contextless if we didn't
change
> the selected folder to match what was clicked.

Sorry, I mean it clears the current selection in the list even if it's the same
folder.

[tsergeant, 2017-06-15 05:48:56]

Patchset #3 (id:40001) has been deleted

[tsergeant, 2017-06-15 05:50:26]

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/folder_node.js (right):

https://codereview.chromium.org/2926233002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/folder_node.js:268: this.selectFolder_();
On 2017/06/15 03:48:52, calamity wrote:
> On 2017/06/13 07:01:54, tsergeant wrote:
> > On 2017/06/13 05:54:25, calamity wrote:
> > > This clears the current selection in the list. Is this intentional?
> > 
> > Yeah, this is intentional (and matches the old BMM).
> > 
> > I was finding that the context menu felt really contextless if we didn't
> change
> > the selected folder to match what was clicked.
> 
> Sorry, I mean it clears the current selection in the list even if it's the
same
> folder.

Ah, I see. This was a problem with just left-clicking the node as well.

Fixed.

[calamity, 2017-06-16 03:45:04]

lgtm

[tsergeant, 2017-06-16 03:54:52]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:55:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 05:22:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497585292952630,
"parent_rev": "7ab74b4b9234e3f9e8a6ba86dd803eaa33d138bd", "commit_rev":
"a274e041953915ac3c48d4bbb1c6d360253bffba"}

[commit-bot: I haz the power, 2017-06-16 05:22:45]

Description was changed from

==========
MD Bookmarks: Add right-click context menu to sidebar folders

Right clicking a folder in the sidebar will select that folder and
show the menu of edit/open commands for that folder.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Add right-click context menu to sidebar folders

Right clicking a folder in the sidebar will select that folder and
show the menu of edit/open commands for that folder.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2926233002
Cr-Commit-Position: refs/heads/master@{#479957}
Committed:
https://chromium.googlesource.com/chromium/src/+/a274e041953915ac3c48d4bbb1c6...
==========

[commit-bot: I haz the power, 2017-06-16 05:22:47]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a274e041953915ac3c48d4bbb1c6...