MD Bookmarks: Add right-click context menu to sidebar folders

chrome/browser/resources/md_bookmarks/folder_node.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-folder-node',
 
   behaviors: [
     bookmarks.StoreClient,
   ],
@@ skipping 238 matching lines @@
    * @private
    * @return {string}
    */
   getFolderIcon_: function() {
     return this.isSelectedFolder_ ? 'bookmarks:folder-open' : 'cr:folder';
   },
 
   /** @private */
   selectFolder_: function() {
     this.dispatch(
-        bookmarks.actions.selectFolder(this.item_.id, this.getState().nodes));
+        bookmarks.actions.selectFolder(this.itemId, this.getState().nodes));
   },
 
   /**
+   * @param {!Event} e
+   * @private
+   */
+  onContextMenu_: function(e) {
+    e.preventDefault();
+    this.selectFolder_();

[calamity, 2017/06/13 05:54:25]

This clears the current selection in the list. Is this intentional?

[tsergeant, 2017/06/13 07:01:54]

Yeah, this is intentional (and matches the old BMM).

I was finding that the context menu felt really contextless if we didn't change
the selected folder to match what was clicked.

[calamity, 2017/06/15 03:48:52]

Sorry, I mean it clears the current selection in the list even if it's the same
folder.

[tsergeant, 2017/06/15 05:50:26]

Ah, I see. This was a problem with just left-clicking the node as well.

Fixed.

+    bookmarks.CommandManager.getInstance().openCommandMenuAtPosition(
+        e.clientX, e.clientY, new Set([this.itemId]));
+  },
+
+  /**
    * @private
    * @return {!Array<!BookmarksFolderNodeElement>}
    */
   getChildFolderNodes_: function() {
     return Array.from(this.root.querySelectorAll('bookmarks-folder-node'));
   },
 
   /**
    * Occurs when the drop down arrow is tapped.
    * @private
    * @param {!Event} e
    */
   toggleFolder_: function(e) {
     this.dispatch(
-        bookmarks.actions.changeFolderOpen(this.item_.id, this.isClosed_));
+        bookmarks.actions.changeFolderOpen(this.itemId, this.isClosed_));
     e.stopPropagation();
   },
 
   /**
    * @private
    * @param {!Event} e
    */
   preventDefault_: function(e) {
     e.preventDefault();
   },
@@ skipping 47 matching lines @@
   },
 
   /**
    * @private
    * @return {string}
    */
   getTabIndex_: function() {
     return this.isSelectedFolder_ ? '0' : '';
   },
 });