Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2926143003: Web MIDI: restore sysex receiving buffer synchronously (Closed)

Created:
3 years, 6 months ago by Takashi Toyoshima
Modified:
3 years, 6 months ago
Reviewers:
yukawa, yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: restore sysex receiving buffer synchronously The new backend restores sysex receiving buffer asynchronously, but it turned out that this way causes a receiving data loss on receiving continuous sysex messages. The original backend did it synchronously and didn't have such problem. So let me fix the new backend to take the same approach. BUG=730647 Review-Url: https://codereview.chromium.org/2926143003 Cr-Commit-Position: refs/heads/master@{#477807} Committed: https://chromium.googlesource.com/chromium/src/+/1814e6af281cd1f00ddf0705c01e2484708b0e4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/midi/midi_manager_win.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Takashi Toyoshima
Can you review this small code change? This change needs to be merged to release ...
3 years, 6 months ago (2017-06-07 16:25:38 UTC) #5
yukawa
lgtm
3 years, 6 months ago (2017-06-07 16:28:43 UTC) #6
Takashi Toyoshima
Thank you for a quick review!
3 years, 6 months ago (2017-06-07 16:40:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926143003/1
3 years, 6 months ago (2017-06-07 19:45:38 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 23:46:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1814e6af281cd1f00ddf0705c01e...

Powered by Google App Engine
This is Rietveld 408576698